Let user update the app #355
Open
+352
−135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktprograms
requested changes
Oct 3, 2022
app/src/main/java/com/odysee/app/ui/findcontent/AllContentFragment.java
Outdated
Show resolved
Hide resolved
app/src/main/java/com/odysee/app/ui/findcontent/AllContentFragment.java
Outdated
Show resolved
Hide resolved
app/src/main/java/com/odysee/app/ui/findcontent/AllContentFragment.java
Outdated
Show resolved
Hide resolved
app/src/main/java/com/odysee/app/ui/findcontent/AllContentFragment.java
Outdated
Show resolved
Hide resolved
app/src/main/java/com/odysee/app/ui/findcontent/AllContentFragment.java
Outdated
Show resolved
Hide resolved
ktprograms
reviewed
Oct 3, 2022
How is this expected to work?After a new version is released -I mean, after |
|
I see, that makes sense. |
akinwale
approved these changes
Nov 4, 2022
# Conflicts: # app/src/main/res/layout/fragment_all_content.xml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check all that apply to this PR using "x":
PR Type
What kind of change does this PR introduce?
Fixes
Issue Number:
#328
What is the current behavior?
For packages installed not from Play Store or FDroid, user needs to manually download the app and install it
What is the new behavior?
The app will show a snackbar when a new version is released, allowing user to install it
Notes
This PR requires that certain file exists on the update server. That file must be have a JSON format. The specification is documented on this PR code.
JSON file name and hosting can be changed. In order for this to be tested, I used my own web server, where I put a JSON file and an APK built from master branch but with a version code of 17.
To avoid accidental updates of the app while developing, the code will not run for DEBUG builds. In order to test this PR, you will need to comment out the corresponding code which checks for DEBUG builds.
New version code checking will run once every 24 hours, but user could still force the checking by quiting the app and restarting it.