Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smooth livestream's list displaying #407

Merged
merged 2 commits into from
Nov 14, 2022
Merged

Smooth livestream's list displaying #407

merged 2 commits into from
Nov 14, 2022

Conversation

kekkyojin
Copy link
Collaborator

PR Checklist

Please check all that apply to this PR using "x":

  • I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
  • I have checked that this PR does not introduce a breaking change

PR Type

What kind of change does this PR introduce?

  • Bugfix

Fixes

Issue Number:
#406 (partial)

What is the current behavior?

List pop ups

What is the new behavior?

List is shown and then hidden if there are no items to be listed

Other information

This is also fixing the problem on the channet content

@kekkyojin kekkyojin requested a review from akinwale November 13, 2022 20:49
@kekkyojin
Copy link
Collaborator Author

Categories now have a dedicated section to show currently active livestreams. However, if a channel on the category had a livestream, it is also shown on the content list. This PR is also fixing this problem about same item being shown both on the livestreams section and on the content section

Copy link
Contributor

@akinwale akinwale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@kekkyojin kekkyojin merged commit e4a467e into master Nov 14, 2022
@kekkyojin kekkyojin deleted the smooth-livestreams branch November 14, 2022 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bugs for livestream's list on categories rabbit hole livestream - smooth out loading?
2 participants