Fix Ansible warnings

Oefenweb · Nov 29, 2018 · b37e78c · b37e78c
1 parent 56eb618
commit b37e78c
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/.travis.yml b/.travis.yml
@@ -58,7 +58,7 @@ script:
     && (echo 'Idempotence test: pass' && exit 0)
     || (echo 'Idempotence test: fail' && exit 1)
 
-  - if [ "$ANSIBLE_VERSION" = "latest" ]; then ansible-lint tests/test.yml || true; fi
+  - if [ "$ANSIBLE_VERSION" = "latest" ]; then ansible-lint tests/test.yml; fi
 
 notifications:
   email: false

diff --git a/meta/main.yml b/meta/main.yml
@@ -1,6 +1,7 @@
 # meta file for dropbox
 ---
 galaxy_info:
+  role_name: dropbox
   author: Mischa ter Smitten
   company: Oefenweb.nl B.V.
   description: Set up Dropbox in Debian-like systems

diff --git a/tasks/main.yml b/tasks/main.yml
@@ -2,11 +2,10 @@
 ---
 - name: install | dependencies
   apt:
-    name: "{{ item }}"
+    name: "{{ dropbox_dependencies }}"
     state: "{{ apt_install_state | default('latest') }}"
     update_cache: true
     cache_valid_time: "{{ apt_update_cache_valid_time | default(3600) }}"
-  with_items: "{{ dropbox_dependencies }}"
   tags:
     - dropbox-install-dependencies
 
@@ -29,6 +28,7 @@
     -o {{ dropbox_downloads_path }}/dropbox_{{ dropbox_version }}_{{ dropbox_machine_map[ansible_machine] }}.deb
   args:
     creates: "{{ dropbox_downloads_path }}/dropbox_{{ dropbox_version }}_{{ dropbox_machine_map[ansible_machine] }}.deb"
+    warn: false
   tags:
     - configuration
     - dropbox