Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NIT-2437] Propogate error as reason while stopping flatTracer #307

Closed
wants to merge 1 commit into from
Closed

[NIT-2437] Propogate error as reason while stopping flatTracer #307

wants to merge 1 commit into from

Conversation

amsanghi
Copy link
Contributor

@amsanghi amsanghi commented Apr 22, 2024 •
edited
Loading

Thanks @tsahee for figuring out the issue!

@cla-bot cla-bot bot added the s CLA signed label Apr 22, 2024
@amsanghi amsanghi requested a review from tsahee April 22, 2024 17:09
@amsanghi amsanghi marked this pull request as ready for review April 22, 2024 17:09
@amsanghi amsanghi changed the title Propogate error as reason while stopping flatTracer [NIT-2437] Propogate error as reason while stopping flatTracer Apr 22, 2024
@PlasmaPower
Copy link
Collaborator

Sorry I didn't see this PR. I made one copy-pasting Infura's new approach (which matches @tsahee's suggestion) here: #310

I'll close this one accordingly. Thanks for helping out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsahee tsahee tsahee left review comments

Assignees
No one assigned
Labels
s CLA signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amsanghi @PlasmaPower @tsahee