Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flush triedb function #398

Merged
merged 8 commits into from
Jan 23, 2025
Merged

Flush triedb function #398

merged 8 commits into from
Jan 23, 2025

Conversation

diegoximenes
Copy link
Contributor

@diegoximenes diegoximenes commented Jan 21, 2025

Related to NIT-3047

Pulled in by OffchainLabs/nitro#2892

  • Adds metrics related to triedb size and gcproc
  • Adds function to flush triedb to BlockChain

@diegoximenes diegoximenes force-pushed the triedb_commit_maintenance branch from 30f8d40 to 48ee16b Compare January 21, 2025 17:20
@diegoximenes diegoximenes marked this pull request as ready for review January 21, 2025 19:35
magicxyyz
magicxyyz previously approved these changes Jan 21, 2025
Copy link
Contributor

@magicxyyz magicxyyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, added comment to Cap/Commit order

core/blockchain_arbitrum.go Outdated Show resolved Hide resolved
core/blockchain_arbitrum.go Outdated Show resolved Hide resolved
@diegoximenes diegoximenes requested a review from tsahee January 23, 2025 19:35
@joshuacolvin0
Copy link
Member

Need to make matching PR in nitro repo to pull changes in, and add links between the PRs.

Copy link
Collaborator

@tsahee tsahee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tsahee tsahee enabled auto-merge January 23, 2025 23:10
@tsahee tsahee merged commit 95d405a into master Jan 23, 2025
8 checks passed
@tsahee tsahee deleted the triedb_commit_maintenance branch January 23, 2025 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants