-
Notifications
You must be signed in to change notification settings - Fork 487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NIT-2640] Add EVM tracing for Stylus programs #2530
Merged
Merged
Changes from 16 commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
4916517
Add EVM tracing for Stylus programs
gligneul 17383cc
Merge branch 'master' into gligneul/stylus-tracing
gligneul dcf63f7
Merge branch 'master' into gligneul/stylus-tracing
gligneul 1896ae2
Merge branch 'master' into gligneul/stylus-tracing
gligneul 8e08db3
Improve call and exit in stylus tracing
gligneul 9ae5f81
Merge remote-tracking branch 'refs/remotes/origin/gligneul/stylus-tra…
gligneul 3fc95e6
Merge remote-tracking branch 'origin/master' into gligneul/stylus-tra…
gligneul bd680dd
Merge branch 'master' into gligneul/stylus-tracing
gligneul 8668262
Add skeleton for wasm/evm trace equivalence test
gligneul 1934ae6
Merge branch 'master' into gligneul/stylus-tracing
gligneul eeeeb87
Add equivalence test between wasm and evm traces
gligneul db0a7d0
Revert change to nitro-testnode
gligneul 9c49c87
Merge branch 'master' into gligneul/stylus-tracing
gligneul f149133
Merge branch 'master' into gligneul/stylus-tracing
gligneul dd14c87
Merge branch 'master' into gligneul/stylus-tracing
gligneul 45eb7bf
Merge branch 'master' into gligneul/stylus-tracing
gligneul 28f3c87
Properly handle the stylus cache when tracing
gligneul a88b62a
Report remaining gas instead of start gas
gligneul 50b2fb4
Check return opcodes in equivalence test
gligneul d3273f8
Merge branch 'master' into gligneul/stylus-tracing
gligneul 8056328
Add helpers to append load and store to multicall
gligneul 8960b3c
Use helpers to build multicall args
gligneul dee3720
Merge branch 'master' into gligneul/stylus-tracing
gligneul 09228fc
Merge branch 'master' into gligneul/stylus-tracing
gligneul c6d983c
Fix typo in hostio name
gligneul 2a7749d
Merge branch 'master' into gligneul/stylus-tracing
gligneul 3196b7a
Merge branch 'master' into gligneul/stylus-tracing
gligneul d6ea435
Merge branch 'master' into gligneul/stylus-tracing
gligneul 822b4ca
Merge branch 'master' into gligneul/stylus-tracing
gligneul 710f61b
Merge branch 'master' into gligneul/stylus-tracing
gligneul 5a6b060
Merge branch 'master' into gligneul/stylus-tracing
gligneul File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why don't I see a signature change for the trace! macro in this PR?
Was it modified in an earlier PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
trace
macro was already working correctly on the Stylus side. This PR adds the trace handling on the host/nitro side.Regarding this change, I swapped the arguments and outputs to better reflect the semantics of the fields. The return value was being sent as an argument instead of an output. It wasn't a problem until now because this was not being used before.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you might need a corresponding change to cargo-stylus here, but I'm not sure https://github.com/OffchainLabs/cargo-stylus/blob/794221e183cdfd791a2b5be04ec2ab762b381269/replay/src/trace.rs#L367
(also applies to the other tracing order changes)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I opened a PR on cargo stylus updating the API: OffchainLabs/cargo-stylus#73