Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Updates to the upgrade summary doc #8704

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

therealjohn
Copy link
Contributor

Adjusted the information in the upgrade summary.

@therealjohn therealjohn marked this pull request as ready for review May 13, 2023 02:10
@codecov
Copy link

codecov bot commented May 13, 2023

Codecov Report

Merging #8704 (ff34e9e) into dev (6d28192) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #8704   +/-   ##
=======================================
  Coverage   78.96%   78.96%           
=======================================
  Files         608      608           
  Lines       41827    41827           
  Branches     8295     8295           
=======================================
  Hits        33030    33030           
  Misses       5460     5460           
  Partials     3337     3337           

jidddddd
jidddddd previously approved these changes May 15, 2023
@wenytang-ms wenytang-ms changed the title Updates to the upgrade summary doc docs: Updates to the upgrade summary doc May 15, 2023
adashen
adashen previously approved these changes May 15, 2023
xzf0587
xzf0587 previously approved these changes May 15, 2023

1. Created `teamsapp.yml` and `teamsapp.local.yml` in your project root folder.
1. Created `teamsapp.yml` and `teamsapp.local.yml` in your projects root directory.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in your project's root directory?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated in the new PR: #8710

* Configuration of the lifecycle management using Provision, Deploy, and Publish are now fully customizable and expressed in `teamsapp.local.yml` and `teamsapp.yml`. [More info](https://aka.ms/teamsfx-v5.0-guide#project-files)
* Configuration and values that were saved in `.fx/config` and `.fx/state` are now handled with environment files and saved to `/env` by default. [More info](https://aka.ms/teams-toolkit-5.0-upgrade#environment-management)
* The changes to use environment files give greater flexibility of configuring which resources are used to provision, but may require some manual steps when creating new environments. [More info](https://aka.ms/teams-toolkit-5.0-upgrade#environment-management)
* Teams Toolkit no longer prompts you for which environment to use when using the Launch targets in `launch.json`. You can edit `.vscode/launch.json` and configure which environments are used. [More info](https://aka.ms/teams-toolkit-5.0-upgrade#launch-your-app)
Copy link
Contributor

@blackchoey blackchoey May 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed with @kuojianlu , this limitation no longer exists in V5 stable release. Teams Toolkit V5 will ask users select an env as usual. Can you help remove this?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated in the new PR: #8710

@blackchoey blackchoey changed the base branch from dev to main May 15, 2023 05:52
@blackchoey blackchoey dismissed stale reviews from xzf0587, adashen, and jidddddd May 15, 2023 05:52

The base branch was changed.

@blackchoey
Copy link
Contributor

@therealjohn I ported your changes to #8710 because this PR cannot be updated to merge to main branch directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants