Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Carlos redo anniversary celebrated #1185

Merged
merged 3 commits into from
Jan 16, 2025

Conversation

cgomezhub
Copy link
Contributor

@cgomezhub cgomezhub commented Dec 18, 2024

This part of a new Report Page: Create Company Summary Dashboard for Admins requested by Jae.
Implements # (WBS)
Anniversary Celebrared Component

Related PRS (if any):
This Backend PR is related to FPR#2772

this PR fix previus PR#1128

Main changes explained:
Visualization of volunteer anniversaries within the current week.
Comparison of volunteer anniversaries between the current and previous week.
Clicking on the volunteer email icon allows you to send a personalized congratulatory email using previously configured -
Gmail OAuth settings. (For more information on Gmail setup, please watch the video below.)

How to test:
Check out the current branch.
Do npm install and ... to run this PR locally.
Clear site data/cache.
Log in as admin user.
Navigate to Dashboard > Reports > Total Org Summary > Volunteer Engagement Trends.
Set up the Gmail Api in your account http://console.cloud.google.com/ and https://developers.google.com/ (please watch the Gmail Api setup video below until minut 7).
Set up the environment variables in the .env file of your backend project (see .env image).
Chech the anniversary list.
Select and click on the email icon.
Send a congratulatory email.
Check sent folder of your gmail acount
Screenshots or videos needed:
App features video:

https://www.loom.com/share/d4f75956df7b4ef6946dd17aa8bfa806?sid=fc6227af-88b0-41ec-b0bc-4613367dc07f

Gmail Api setup video (just watch until minut 7)
https://www.youtube.com/watch?v=-rcRf7yswfM&list=LL&index=8&t=304s

@cgomezhub cgomezhub added the High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible label Jan 14, 2025
Copy link
Contributor

@strallia strallia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working Features:

I confirm that sending an email through the HGN app does send an email from my gmail account which is shown in my Sent mailbox:

gmail API 2

Issues:

When an image is attached to the email it does not show up in the actual email. I tested with 2 png images and this is how the email looked:

image Screenshot 2025-01-14 at 11 43 57 AM

Also, it seems like the pre-populated email is not meant to be changed. However, when I write or paste a new email address, even though there are no visual changes, the email will be sent to the updated address.

Screen.Recording.2025-01-14.at.11.49.03.AM.mov
Screenshot 2025-01-14 at 11 50 00 AM

@cgomezhub
Copy link
Contributor Author

cgomezhub commented Jan 16, 2025

@strallia
The changes you have requested do not correspond to this PR. The work of this PR is to manage sending or not sending an email, integrating the Gmail API, which as you have already tested, is working correctly.

For your suggestions, I will create a new PR in the Fronted app.

Thanks for your feedback.

Copy link
Contributor

@strallia strallia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cgomezhub Ok sounds good. Approving this PR.

@one-community
Copy link
Member

Thank you all, merging!

@one-community one-community merged commit b13e8bb into development Jan 16, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants