Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abdel log requested time off for blue squares #592

Merged

Conversation

abdel-lall
Copy link
Contributor

Related PRS:

This backend PR is related to the #1471 frontend PR.

How to test:

  1. check into current branch
  2. do npm run build

Copy link
Contributor

@this-journey this-journey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my review on the FE.

Copy link

@pika-chu11 pika-chu11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed both PRs, I have left a review on the FronEnd #1417.

Copy link
Contributor

@pshereen pshereen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed both frontend and backend PRs.
Please check my comments on related Front PR. https://github.com/OneCommunityGlobal/HighestGoodNetworkApp/pull/1471#pullrequestreview-1831620635

Copy link

@Sophie-lei Sophie-lei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tasted this PR with FE. Please view the #1471 FE for details. I think the email function has some problems to be solved in BE.

Copy link

@Renanluizssx Renanluizssx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@one-community one-community dismissed stale reviews from Sophie-lei and this-journey January 29, 2024 05:10

Double checked by Abdel

@one-community one-community merged commit 6ab1216 into development Jan 29, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants