-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Abdel log requested time off for blue squares #592
Abdel log requested time off for blue squares #592
Conversation
…ff_for_blue_squares
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my review on the FE.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed both PRs, I have left a review on the FronEnd #1417.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed both frontend and backend PRs.
Please check my comments on related Front PR. https://github.com/OneCommunityGlobal/HighestGoodNetworkApp/pull/1471#pullrequestreview-1831620635
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tasted this PR with FE. Please view the #1471 FE for details. I think the email function has some problems to be solved in BE.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see my review please: OneCommunityGlobal/HighestGoodNetworkApp#1471
Double checked by Abdel
Related PRS:
This backend PR is related to the #1471 frontend PR.
How to test:
npm run build