Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leon and Oleksandr add interactive map #599

Merged
merged 39 commits into from
Nov 25, 2023

Conversation

xaanders
Copy link
Contributor

@xaanders xaanders commented Nov 8, 2023

Description

See PR #1503

Related PRS :

To test this backend PR you need to checkout the #1503 frontend PR.

Main changes explained:

  • added map location controller, router and mongoose model
  • changed user profile model to handle location object

How to test:

1.get the API key from https://opencagedata.com/
2. add to env same API key from step 1:
TIMEZONE_PREMIUM_KEY=1234
TIMEZONE_COMMON_KEY=1234
check into current branch
3. do npm install and npm run build && npm start to run this PR localy

leonzh2k and others added 30 commits July 6, 2023 17:55
Add jobTitle and location fields to the userProfile objects
that are sent back to the client when requesting all userProfiles.
These two bits of info are displayed on the interactive map.
Add jobTitle and location fields to the userProfile objects
that are sent back to the client when requesting all userProfiles.
These two bits of info are displayed on the interactive map.
new people to the map(maplocation controller, maplocation router, maplocation model)
Add jobTitle and location fields to the userProfile objects
that are sent back to the client when requesting all userProfiles.
These two bits of info are displayed on the interactive map.
new people to the map(maplocation controller, maplocation router, maplocation model)
Add jobTitle and location fields to the userProfile objects
that are sent back to the client when requesting all userProfiles.
These two bits of info are displayed on the interactive map.
Add jobTitle and location fields to the userProfile objects
that are sent back to the client when requesting all userProfiles.
These two bits of info are displayed on the interactive map.
new people to the map(maplocation controller, maplocation router, maplocation model)
leonzh2k and others added 7 commits November 4, 2023 13:17
Add jobTitle and location fields to the userProfile objects
that are sent back to the client when requesting all userProfiles.
These two bits of info are displayed on the interactive map.
Add jobTitle and location fields to the userProfile objects
that are sent back to the client when requesting all userProfiles.
These two bits of info are displayed on the interactive map.
@xaanders xaanders added the Do Not Review Do not review or look at code without full context label Nov 8, 2023
@xaanders xaanders removed the Do Not Review Do not review or look at code without full context label Nov 13, 2023
Copy link

@Changhao3220K Changhao3220K left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment left in the FE, great work!

@palakgosalia
Copy link

Hey, I have left comments in FE PR. Thank you

@KavyaAlla
Copy link

Hi @xaanders , Review at PR 1503

Copy link
Contributor

@Shuhua-L Shuhua-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test video and comment left in the FE PR. Nice work!

Copy link
Contributor

@robertoooc robertoooc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backend works well, FE just needs one slight adjustment and all will be well.

@beblicarl beblicarl self-requested a review November 24, 2023 14:11
@beblicarl
Copy link
Contributor

tested the frontend and all is well

Copy link
Contributor

@navneeeth navneeeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, @xaanders and @leonzh2k! Commented the full review on the frontend PR. Great job with this implementation!

@one-community one-community merged commit 6c93273 into development Nov 25, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants