-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Leon and Oleksandr add interactive map #599
Conversation
Add jobTitle and location fields to the userProfile objects that are sent back to the client when requesting all userProfiles. These two bits of info are displayed on the interactive map.
Add jobTitle and location fields to the userProfile objects that are sent back to the client when requesting all userProfiles. These two bits of info are displayed on the interactive map.
…unityGlobal/HGNRest into leon_add_interactive_map
new people to the map(maplocation controller, maplocation router, maplocation model)
…cations, put new location to a collection
…all manually locations response structure
Add jobTitle and location fields to the userProfile objects that are sent back to the client when requesting all userProfiles. These two bits of info are displayed on the interactive map.
new people to the map(maplocation controller, maplocation router, maplocation model)
…cations, put new location to a collection
…all manually locations response structure
Add jobTitle and location fields to the userProfile objects that are sent back to the client when requesting all userProfiles. These two bits of info are displayed on the interactive map.
…all manually locations response structure
…unityGlobal/HGNRest into leon_add_interactive_map
Add jobTitle and location fields to the userProfile objects that are sent back to the client when requesting all userProfiles. These two bits of info are displayed on the interactive map.
new people to the map(maplocation controller, maplocation router, maplocation model)
…cations, put new location to a collection
…all manually locations response structure
Add jobTitle and location fields to the userProfile objects that are sent back to the client when requesting all userProfiles. These two bits of info are displayed on the interactive map.
…all manually locations response structure
Add jobTitle and location fields to the userProfile objects that are sent back to the client when requesting all userProfiles. These two bits of info are displayed on the interactive map.
…unityGlobal/HGNRest into leon_add_interactive_map
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment left in the FE, great work!
Hey, I have left comments in FE PR. Thank you |
Hi @xaanders , Review at PR 1503 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test video and comment left in the FE PR. Nice work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Backend works well, FE just needs one slight adjustment and all will be well.
tested the frontend and all is well |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description
See PR #1503
Related PRS :
To test this backend PR you need to checkout the #1503 frontend PR.
…
Main changes explained:
How to test:
1.get the API key from https://opencagedata.com/
2. add to env same API key from step 1:
TIMEZONE_PREMIUM_KEY=1234
TIMEZONE_COMMON_KEY=1234
check into current branch
3. do
npm install
andnpm run build && npm start
to run this PR localy