Haoji fetch profile images from team page and sending email for selecting correct images #608

Haoj1 · 2023-11-12T07:19:54Z

Description

Related PRS (if any):

To test this backend PR you need to checkout the #1531 frontend PR.
The main changes are based on the previous PR: #591.
…

Main changes explained:

Update package.json for Web Scraping tools
Update src/controllers/userProfileController.js for allowing url as a valid img source
Create a function updateProfilesPic in src/controllers/userProfileController.js for fetching the pictures from the sites
Update src/models/userProfile.js to allow temporarily store the possible pictures
Create an email sender for alerting the user if there are more than one possible imgs fetched by the cronjob
…

How to test

check into current branch
do npm install, npm run build and npm run start to run this PR locally
log as owner user
Please change the cronjob interval in src/cronjobs/userProfileJobs.js, the following change allows cronjob to run every minute. You could make the interval longer appropriately for testing. If you forget to change this, cronjob would only run everyday 12:00am

If you do not want to modify others' profiles during testing, you can add a search keyword in src/helpers/userHelper.js like the following. That could make sure cronjob only works on your own created users.

See how to test in frontend
do git restore . to undo the changes

Screenshots or videos of changes:

Note:

See frontend

…m-Website

…oji-alert-multiple-images-and-selection-for-individuals

…tion-for-individuals

ptrpengdev · 2023-12-03T03:22:51Z

Tested with FE PR 1471. The PR worked as expected.

ljrirene

Hi Haoji, I got the same issue here. The permission list can't be scrolled down.

Screen.Recording.2023-12-09.at.03.19.44.mov

Haoj1 · 2023-12-11T23:59:32Z

1471

Hi @ljrirene I did not update the permission list in Frontend. Did you checkout into a different branch in FE? Thank you

Sophie-lei

Hey! I tested this PR and left a comment in PR#1531. Please review.

Pandani07

Hello, the backend console keeps showing "update picture" whenever I create a new user with the same name, but no photo gets added to the user profile. I have attached a video for your reference.

Screen.Recording.2024-02-02.at.1.44.35.PM.mov

XiaohanMeng

Hi, I tested this PR and commented at FE project: OneCommunityGlobal/HighestGoodNetworkApp#1531

…tion-for-individuals

DiegoSalas27

I have made an inline comment in the userHelper.js file suggesting a code change to prevent non active users profile images being updated. Overall, great work!

screen-recording-2024-03-01-at-123007-pm_siO0U1qh.mp4

DiegoSalas27 · 2024-03-01T17:23:25Z

src/helpers/userHelper.js

+      });
+
+      for (let profile of userProfiles) {
+        const { firstName, lastName, profilePic, isActive, email } = profile;


Consider using the isActive property, as it's not being used anywhere to prevent assigning a picture to an existing user that is not active. Eg:

if (!isActive) continue

…tion-for-individuals

XiaohanMeng

Hi, I left my latest review here: OneCommunityGlobal/HighestGoodNetworkApp#1531 (review)

DiegoSalas27

Awesome job!

ljrirene

Hi Haoji, I tested case 1&2 here. I used Ivan Manzurov's name for the test. I also changed this line here:

Is there any problem with the way I tested? I didn't get the crawler‘s information in the backend terminal. Please refer to this video:
https://drive.google.com/file/d/1seFbVWXZLhTlTAq4Yn23GcEBgUFdJhEF/view?usp=sharing

kylepham

I left a review on the frontend PR. It seems to fetch multiple images despite unique combination of first and last name.

Also, is the email sending part of the requirements for this PR? I don't see it anywhere in the code and wonder if reviewers should set it up ourselves.

hetvi11110

I have tested frontend and backend PR and left a comment on frontend PR. Please review there.

juneluo and others added 12 commits September 15, 2023 06:08

select profilePic as userProfile

11892e4

add fecthUserProfilePics

ceee25f

finish fetch the images from the website

f4c50d2

Merge branch 'development' into Haoji-Make-App-Get-Profile-Images-fro…

b287f7b

…m-Website

update userProfileController.js

6a0b2f5

add the feature into cronjob

3079a32

Merge branch 'Haoji-Make-App-Get-Profile-Images-from-Website' into Ha…

31170e5

…oji-alert-multiple-images-and-selection-for-individuals

verify user is active and sending email

cf06d29

Merge branch 'development' into Haoji-alert-multiple-images-and-selec…

6f156c0

…tion-for-individuals

sending email when multiple imgs

a28615c

Merge branch 'development' into Haoji-alert-multiple-images-and-selec…

6564d20

…tion-for-individuals

update userhelper to send email

07c10bf

Haoj1 mentioned this pull request Nov 12, 2023

Haoji fetch images from team page and multiple profile images selection for individuals OneCommunityGlobal/HighestGoodNetworkApp#1531

Open

Haoj1 changed the title ~~Haoji fetch profile images from team page and~~ Haoji fetch profile images from team page and sending email for selecting correct images Nov 17, 2023

Haoj1 mentioned this pull request Nov 17, 2023

Haoji create a cronjob for app to get profile images from website #591

Closed

one-community added the High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible label Nov 17, 2023

This comment was marked as duplicate.

Sign in to view

ljrirene suggested changes Dec 9, 2023

View reviewed changes

Sophie-lei suggested changes Jan 24, 2024

View reviewed changes

Pandani07 requested changes Feb 2, 2024

View reviewed changes

Haoj1 added 4 commits February 3, 2024 05:01

update crawling proxy

f9c15ed

update crawling proxy in backend

84ac71b

resolved conflict

cdc2a5f

update cronjob period

be4bdc4

XiaohanMeng self-requested a review February 15, 2024 21:04

XiaohanMeng suggested changes Feb 15, 2024

View reviewed changes

Haoj1 added 2 commits February 17, 2024 17:08

merge dev branch

d61d3bd

Merge branch 'development' into Haoji-alert-multiple-images-and-selec…

5954590

…tion-for-individuals

DiegoSalas27 requested changes Mar 1, 2024

View reviewed changes

Haoj1 added 2 commits March 2, 2024 22:05

remove email notification

f6999c1

Merge branch 'development' into Haoji-alert-multiple-images-and-selec…

d2c0241

…tion-for-individuals

XiaohanMeng self-requested a review March 7, 2024 23:39

XiaohanMeng suggested changes Mar 7, 2024

View reviewed changes

DiegoSalas27 approved these changes Mar 8, 2024

View reviewed changes

ljrirene suggested changes Mar 9, 2024

View reviewed changes

update profile api

84832b4

kylepham suggested changes Mar 26, 2024

View reviewed changes

hetvi11110 reviewed Mar 27, 2024

View reviewed changes

Haoj1 added 8 commits March 30, 2024 16:42

remove .DS_store

82888e2

resolve confilct with dev

74723dc

add a error catch in profilecontroller

8d49d43

resolved a conflict in cache

f2e39c5

fix the bug when there is same Last name case

2770eff

resolved the conflict with dev

7082779

change cronjob frequency

6c378cd

fix package.json

9b6ac5b

one-community added Do Not Review Do not review or look at code without full context Needs New Developer This is a PR that is partially developed but needs someone new to take it over and finish it. labels Jul 17, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Haoji fetch profile images from team page and sending email for selecting correct images #608

Haoji fetch profile images from team page and sending email for selecting correct images #608

Haoj1 commented Nov 12, 2023 •

edited

Loading

ptrpengdev commented Dec 3, 2023

This comment was marked as duplicate.

ljrirene left a comment

Haoj1 commented Dec 11, 2023

Sophie-lei left a comment

Pandani07 left a comment •

edited

Loading

XiaohanMeng left a comment

DiegoSalas27 left a comment •

edited

Loading

DiegoSalas27 Mar 1, 2024

XiaohanMeng left a comment

DiegoSalas27 left a comment

ljrirene left a comment

kylepham left a comment •

edited

Loading

hetvi11110 left a comment

Haoji fetch profile images from team page and sending email for selecting correct images #608

Are you sure you want to change the base?

Haoji fetch profile images from team page and sending email for selecting correct images #608

Conversation

Haoj1 commented Nov 12, 2023 • edited Loading

Description

Related PRS (if any):

Main changes explained:

How to test

Please change the cronjob interval in src/cronjobs/userProfileJobs.js, the following change allows cronjob to run every minute. You could make the interval longer appropriately for testing. If you forget to change this, cronjob would only run everyday 12:00am

Screenshots or videos of changes:

Note:

ptrpengdev commented Dec 3, 2023

This comment was marked as duplicate.

ljrirene left a comment

Choose a reason for hiding this comment

Haoj1 commented Dec 11, 2023

Sophie-lei left a comment

Choose a reason for hiding this comment

Pandani07 left a comment • edited Loading

Choose a reason for hiding this comment

XiaohanMeng left a comment

Choose a reason for hiding this comment

DiegoSalas27 left a comment • edited Loading

Choose a reason for hiding this comment

DiegoSalas27 Mar 1, 2024

Choose a reason for hiding this comment

XiaohanMeng left a comment

Choose a reason for hiding this comment

DiegoSalas27 left a comment

Choose a reason for hiding this comment

ljrirene left a comment

Choose a reason for hiding this comment

kylepham left a comment • edited Loading

Choose a reason for hiding this comment

hetvi11110 left a comment

Choose a reason for hiding this comment

Haoj1 commented Nov 12, 2023 •

edited

Loading

Pandani07 left a comment •

edited

Loading

DiegoSalas27 left a comment •

edited

Loading

kylepham left a comment •

edited

Loading