Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

luis fix admins permissions added unassignUserInProject, assignUserInProject permission to creteI… #610

Open
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

luisarevalo21
Copy link
Contributor

Description

Screenshot 2023-11-13 at 8 14 31 PM This PR resolves part C.

Main changes explained:

Added both 'unassignUserInProject' and 'assignUserInProject' to admins permission on initial setup.

How to test:

  1. check into current branch
  2. do npm run build, npm run install npm run start to run this PR locally
  3. Checkout the front end development branch
  4. log as admin user
  5. go to dashboard→ other links → projects
  6. select a project and select the projects team member icons
  7. make sure a red delete button appears next to all users
  8. remove a user and refresh to make sure the user is removed.

Screenshots or videos of changes:

Screen.Recording.2023-11-13.at.8.18.08.PM.mov

@luisarevalo21 luisarevalo21 changed the title added unassignUserInProject, assignUserInProject permission to creteI… luis fix admins permissions added unassignUserInProject, assignUserInProject permission to creteI… Nov 14, 2023
@palakgosalia
Copy link

Hey, I reviewed and tested your PR. I was able to delete the member from the project. Thank you

610.mp4

Copy link

@ljrirene ljrirene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job Luis! This feature works as expected on my side.

Screen.Recording.2023-12-09.at.02.43.35.mov

Copy link

@Alforoan Alforoan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am for some reason unable to click on anything.

pr.review.610.mp4

Copy link
Contributor

@Pandani07 Pandani07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I am not able to click on anything. I also got this in the backend log

Screenshot 2024-02-06 at 8 01 03 PM

Copy link

@akshit0211 akshit0211 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not able to click on anything on the page. Please check this.

error

Copy link
Contributor

@AJAYINAVOLU AJAYINAVOLU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The web page is freezing completely.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants