Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eduardo Add .nvmrc file. Node v14. #612

Merged
merged 1 commit into from
Nov 28, 2023
Merged

Conversation

eduhorta
Copy link
Contributor

@eduhorta eduhorta commented Nov 14, 2023

Description

In this pull request, we're introducing a valuable addition to our project - the .nvmrc file. This file is designed to streamline the process of managing Node.js versions, ensuring that collaborators and contributors use the appropriate version when working on the project.

Related PRS :

Front-end PR.

Main changes explained:

Do you use nvm?
Then you can run nvm install or nvm i in the project folder to install and use the most appropriate version of Node.

Added .nvmrc file:
This file specifies the required Node.js version for the project.

How to test:

  1. check into current branch
  2. do nvm i and npm i to run this PR locally
  3. run npm run dev
  4. log as any user
  5. verify if the app is working properly

Alternative testing

  1. Access the branch URL.
  2. Click on Code -> Create Codespace
image
  1. Wait for the virtual environment to load
image
  1. Run the command
image

Video of change:

2023-11-14.14-22-27.mp4

Note:

If you already have the appropriate version of Node installed in your environment, running the command will perform the checkout.

@eduhorta eduhorta changed the title Eduardo Add .nvmrc file. Node v14. Eduardo Add .nvmrc file. Node v14. Nov 14, 2023
Copy link
Contributor

@tdkent tdkent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Followed instructions, running nvm i set the node version to v14.21.3. App runs correctly.

Copy link

@KurtisIvey KurtisIvey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thought my computer was going to undergo a catastrophic error there for a bit while nvm i was running lol. Have tested it and found it to perform exactly as intended. Really did simplify the process for mac users.

What I did:
Delete my old version of node that I used with HGN (v14.17.6)
confirm deletion with nvm ls
Then run nvm i (takes a bit of time to install, so don't panic)
Afterwards, confirm installation via "nvm ls". You should see the node version installed

Screenshot 2023-11-17 at 10 20 29 AM

Copy link

@sahilpatel18 sahilpatel18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After testing, I found that everything works exactly as intended. Great work!

@palakgosalia
Copy link

Hey, Left a comment in the FE PR. Thank you

Copy link
Contributor

@AaronPersaud AaronPersaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Eduardo, I've tested and it works perfectly!

Running nvm i and switching the versions

image

Running npm i to install node packages

image

@EvianTan EvianTan merged commit fd8647b into development Nov 28, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants