Rhea create newLessom routes and controller #613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Backend Release to Main [0.74]
Backend Release to Main [0.75]
Backend Release to Main [0.76]
Backend Release to Main [0.77]
Backend Release to Main [0.78]
Revert "Backend Release to Main [0.78]"
…-development Revert "Revert "Backend Release to Main [0.78]""
Backend Release to Main [0.79]
Backend Release to Main [0.80]
Backend Release to Main [0.81]
Backend Release to Main [0.82]
Backend Release to Main [0.83]
Backend Release to Main [0.84]
Backend Release to Main [0.85]
Backend Release to Main [0.86]
Backend Release to Main [0.87]
Revert "Backend Release to Main [0.87]"
Backend Release to Main [0.88]
Backend Release to Main [0.89]
Backend Release to Main [0.90]
Backend Release to Main [0.91]
Backend Release to Main [0.92]
Backend Release to Main [0.93]
Backend Release to Main [0.94]
Revert "Backend Release to Main [0.94]"
Backend Release to Main [0.95]
Backend Release to Main [1.19]
Backend Release to Main [1.20]
Backend Release to Main [1.21]
Backend Release to Main [1.22]
Backend Release to Main [1.23]
Revert "Backend Release to Main [1.23]"
Backend Release to Main [1.24]
Backend Release to Main [1.25]
Backend Release to Main [1.26]
tdkent
suggested changes
Dec 18, 2023
Backend Release to Main [1.27]
Backend Release to Main [1.28]
…orking expect empty TAG array
tdkent
suggested changes
Jan 2, 2024
| }; | ||
| const bmPostLessonList = async (req, res) => { | ||
| try { | ||
| const { id, title, content, author, tag, relatedProject} = req.body; |
There was a problem hiding this comment.
- You don't need to deconstruct
req.bodyif you are not using the variables. Line 17 can either be omitted or used to define a new variable such asconst newDoc = req.body; const newLesson = BuildingNewLesson.create(newDoc); tagsis not updating because Mongo ignores fields that don't exactly match the model. Make sure to renametagtotags.
tdkent
suggested changes
Jan 2, 2024
| try { | ||
| const { id, title, content, author, tag, relatedProject} = req.body; | ||
| const newLesson = BuildingNewLesson.create(req.body); | ||
| newLesson.save().then(result => res.status(200).send(result)) |
There was a problem hiding this comment.
- status should be changed to 201, which indicates a new resource was created.
tdkent
suggested changes
Jan 2, 2024
.github/pull_request_template.md
Outdated
| @@ -17,10 +17,9 @@ To test this backend PR you need to checkout the #XXX frontend PR. | |||
| ## How to test: | |||
There was a problem hiding this comment.
- did you mean to revert this file to an older version? Make sure to change it back to its current version if not.
- you can use Source Control in VS Code or
git statusto check which files have been updated before committing. Changes you're not expecting or that are not relevant to your branch can be discarded.
There was a problem hiding this comment.
I'm about to ask you about that, because when I use git status, it showed up that file which I don't even know what that, and I only added my controller file when I did git add <controller name>.
There was a problem hiding this comment.
If you see files that you did not update after using git status I would just discard those changes. Source Control in VSC makes that really easy if you have it set up.
For now, I would just copy/paste the code for this file from the dev branch and make another commit.
tdkent
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is about creating routes and controller for newLesson feature from Phase II, including GET and POST request (with local dummy data)
Or Implements # (phase 2 WBS) 6.3.2
Related PRS (if any):
n/a
Main changes explained:
Add bmNewLesson routes and controller
Note:
This is only interacting with local built-in dummy data, please feel free to test on Postman for GET/POST, will update code with mongoose once schema and db set up