-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shree create blue square reason scheduler forall #614
Shree create blue square reason scheduler forall #614
Conversation
Hi SShree, I attempted to test the pull request function. However, I encountered a challenge during step 5 due to the disabled "Schedule Blue Square Button." I have attached a video to this comment. Environment Setup:
Steps to reproduce the issue:
video1918034154.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I used my email as both the sender and receiver here. Successfully sent a total of 5 emails with different dates.
Each email was appropriately triggered by the system in response to the 'Save' action after scheduling a blue square reason.
Verified the receipt of all 5 emails in the test email account. The content and dates in the received emails were as expected, confirming that the email functionality is operating correctly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Bhagyashree444,
I received email notifications as expected when I successfully set/update a Blue Square Reason. Nice work👏!
My only concern, though, is the changes in .gitattributes
, which are related to the CRLF vs LF battle and have sparked several conversations in Slack. I'm not sure if this is the solution to the linting challenge, but I would recommend that you only commit the changes related to the Blue Square Scheduler. If you want to update git configurations, you can make another PR for that. Once you've addressed these, we're good to merge.
PR1542+614.mov
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Bhagyashree444 , Everything is working as expected. Details at OneCommunityGlobal/HighestGoodNetworkApp#1542 (review)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking solid! Appreciate your effort! 🙌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Bhagyashree444 Looks good to me! Comments are left in frontend PR OneCommunityGlobal/HighestGoodNetworkApp#1542 (review)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
backend works perfectly, tested the gmail API and received the email notification.
good job @Bhagyashree444
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Received email immediately after assigning the blue square.
- Functionality and the validation works fine.
- Below is the video testing functionality of node mailer implementation and integration Gmail API
PR.614.Backend.mp4
Thank you all, moving to final review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment left at frontEnd #1542 great job!
Description
Related PRS (if any):
To test this backend PR you need to checkout the #1542 frontend PR.
Main changes explained:
-Updated src/controllers/reasonSchedulingController.js to remove the condition (scheduler available only to Owner and Admin role) and updated postReason and patchReason functions to generate an email to user role/you on clicking save button.
How to test:
Tips to know before watching the youtube video given below.
Also, We need to understand the 4 different places where we need to make use of the valid working email id.
===========================================================================================
Before moving to testing, firstly you need to set up any role user with your own test email id, so that you will receive an email on this email id. This is only for test purposes.
To send email using Gmail API using OAuth2 and nodemailer, kindly follow the below video and set up a test mail id.
https://www.youtube.com/watch?v=-rcRf7yswfM&t=10s&ab_channel=MafiaCodes
Fill below variable values(fill inside single quotes) in the .env file of the backend.
REACT_APP_EMAIL =''
REACT_APP_EMAIL_CLIENT_ID =''
REACT_APP_EMAIL_CLIENT_SECRET =''
REACT_APP_EMAIL_REFRESH_TOKEN =''
REACT_APP_EMAIL_CLIENT_REDIRECT_URI='https://developers.google.com/oauthplayground'
sendEmail = TRUE
===========================================================================================
Steps how to test
npm install
,npm run build
andnpm start
to run this PR locallyScreenshots or videos of changes:
Pull_Request.mp4
Note:
The Refresh Token gets expired in 7 days, so if you are testing this PR after 7 days of creating the Refresh token then please create new OAuth 2.0 Client ID for the same project and update the variables (mentioned above) in .env file. (to create this follow video from 3.20 timestamp )