Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Luis Fix project update speed on user profile and on time-log #1496

Conversation

luisarevalo21
Copy link
Contributor

@luisarevalo21 luisarevalo21 commented Nov 6, 2023

Description

Screenshot 2023-11-05 at 7 26 53 PM

Related PRS (if any):

This frontend PR is related to the #596 backend PR.

Main changes explained:

On the backend I added a check to remove cache.
The issue was the backend was sending back old cache instead of clearing it when a project was added.
Hence it was sending old data.
The change occurs in ProjectController.js inside of the assignProjectToUsers() when mapping over each element cache is checked if so it removes it and adds the user.

How to test:

  1. check into current branch
  2. do npm run install and then npm run start
  3. log as admin user
  4. go to view-profile→ projects→ take note how many projects are there.
  5. Next go to other links → projects → select a project → add your current user that you are logged in as.
  6. Add the user then navigate to the view-profile→ projects→ and check if the project was added to the list of projects.
  7. Next click timelog check to see if the project is in the list of tasks.
  8. click "add tangible time entry"
  9. click on projects/task and see if the newly added project is inside of the drop down menu

Screenshots or videos of changes:

Screen.Recording.2023-11-05.at.7.09.11.PM.mov
Screen.Recording.2023-11-05.at.7.25.40.PM.mov

Note:

Include the information the reviewers need to know.

Copy link
Contributor

@malikjahanzaib malikjahanzaib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @luisarevalo21, I have tested this PR and it works as intended (Great job!!!). When a user is added to a project it gets reflected immediately in the user profile and timelog as well. One thing I noticed is that when an intangible time entry is logged under the newly added project, that project gets removed from the user it was assigned to. Is this the expected behavior? Check out my test recording for reference.

Test rec:

06.11.2023_21.47.58_REC.mp4

Copy link
Contributor

@Shuhua-L Shuhua-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PS: Oops, I didn't notice the 'Do not review' tag when I started my review. Happy to take another look if you make any changes and want a fresh review.


Hi, I've tested your PRs locally: When a project was assigned to an admin, both the 'User Profile' section and the 'Timelog' section updated instantly. The same holds for volunteer users (See screen recording part 1). Great work!

However, as malikjahanzaib mentioned, the newly added project disappears after adding an intangible time entry, but this only happens for admin users. When I tried it with volunteer users, it worked well (See screen recording part 2). I hope this information is helpful.

PR1496+596-part1.mov
PR1496+596-part2.mov

@LunaticLeo LunaticLeo deleted the fix_project_update_speed_on_user_profile_and_delete_users_from_projects branch December 8, 2023 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants