-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Xiao F Create way for owner to edit & update ChatGPT prompt text #1510
Xiao F Create way for owner to edit & update ChatGPT prompt text #1510
Conversation
…pdate-ChatGPT-prompt-text
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @tsunami776 , I have reviewed your pull request and tested it. It works as you intended. Well done!
…pdate-ChatGPT-prompt-text
Just finished reviewing your changes and everything works as intended. See attached video. PR.603.FE.mov |
I tested your PR on both an Owner and Volunteer account. On the owner account, the edit button appeared, and the edit functionality worked as intended. On the volunteer account, the edit button did not appear as intended. On both accounts, I was able to copy the prompt as intended. Please see the overview video for more details: 2023-12-02.10-44-54.mov |
Hi @tsunami776 , I tested your PR, and the code works as expected. Great job! Login as Owner role: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @tsunami776
I have tested all the new features, and all of them worked as intended.
(1) When I log in as Owner, I can click on the edit prompt and change the current prompt.
(2) After saving the prompt, I can also use the copy function, no error occurred.
(3) When I log in as a Volunteer, I cannot edit the prompt, I only see the latest change for the prompt.
(4) the copy function worked very well for the volunteer role.
Here are the two videos for the test process.
Screen.Recording.2023-12-07.at.14.19.31.mov
Screen.Recording.2023-12-07.at.14.18.09.mov
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @tsunami776 I conducted tests on this PR both as the Owner and as a Volunteer. Upon my initial login and clicking the "View and Copy Current AI Prompt," I noticed that the default prompt was not displayed. However, I managed to rectify this by clicking the edit button and pasting the prompt into the box, successfully saving it. I believe it would be beneficial if the default prompt could be set in the initial state. This would allow users to easily copy the prompt in the case of a Volunteer, and Owners could then have the option to edit the prompt as needed.
PR1510+603_recording.mov
I don't see any issues other than the one mentioned earlier. Overall, the features are working as intended. Great job!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @tsunami776 , I have tested your PR with different roles of account. The code works as intended that only the Owner have the permission to edit the ChatGPT prompt text while other account like Manager, Mentor, CoreTeam, Volunteer, and Admin cannot do that.
Great Job!
Check the video below for details:
PR.1510.mp4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It all seems to work as intended. Nice!
pr.review.1510.mp4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job Xiaofei, everything works perfectly on my side.
Screen.Recording.2023-12-23.at.17.47.19.mov
Hi @tsunami776 , I have reviewed your pull request and tested it. It works as intended. Good Job!
Logged in as volunteer, the edit button is not present and see the updated prompt |
…pdate-ChatGPT-prompt-text
a712069
Thank you all, moving to final review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you all, merging! |
Thank you all, merging! |
Description
Related PRS (if any):
To test this front-end PR you need to checkout the #603 back-end PR.
Main changes explained:
src/components/WeeklySummary/CurrentPromptModal.jsx
to get and update prompt with a fallback prompt if error occursHow to test:
npm install
andnpm run start:local
to run this PR locallyScreenshots or videos of changes:
AI.Prompt.Test.mp4
Note:
N/A