-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Yashwanth individual permission change show #2868
Yashwanth individual permission change show #2868
Conversation
✅ Deploy Preview for highestgoodnetwork-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @yashwanth170
I have tested this , and it is displaying the text Loading for a long time instead of a table and I hjave also tried using clearing the cache.
Thank you.
Hello, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of this logic should be on the backend. The only frontend changes required should be accommodating the new info in the permissionChangeLogTable
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The table doesn't show, and I have done git checkout for backend PR #1149.
…ighestGoodNetworkApp into Yashwanth_individual_permission_change_show
…ighestGoodNetworkApp into Yashwanth_individual_permission_change_show
…ighestGoodNetworkApp into Yashwanth_individual_permission_change_show
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have to be logged into an Owner account to see the table. |
…ighestGoodNetworkApp into Yashwanth_individual_permission_change_show
Thank you all, merging! |
Description
The permission change log table only logs changes made to role, so I have added additional features to log permission changes made to individual account. Now the table shows latest logs of changes made to both individual and role
Related PRS (if any):
This frontend PR is related to the #1149 backend PR.
To test this frontend PR you need to checkout the 'Yashwanth_individual_permission_change_show_backend' Backend PR.
…
Main changes explained:
How to test:
npm install
and...
to run this PR locallyScreenshots or videos of changes:
Note:
Test it across different user types, and let me know if I missed any expected conventions or if you have any other suggestions.