Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable bitcode for OneSignalNotificationServiceExtension #546

Closed
wants to merge 1 commit into from

Conversation

stopiccot
Copy link
Contributor

@stopiccot stopiccot commented Oct 18, 2022

Fix for the #540

According to Xcode documentation bitcode is no longer supported by Xcode 14

https://developer.apple.com/documentation/xcode-release-notes/xcode-14-release-notes

Starting with Xcode 14, bitcode is no longer required for watchOS and tvOS applications, and the App Store no longer accepts bitcode submissions from Xcode 14.

Xcode no longer builds bitcode by default and generates a warning message if a project explicitly enables bitcode: “Building with bitcode is deprecated. Please update your project and/or target settings to disable bitcode.” The capability to build with bitcode will be removed in a future Xcode release. IPAs that contain bitcode will have the bitcode stripped before being submitted to the App Store. Debug symbols for past bitcode submissions remain available for download. (86118779)


This change is Reviewable

@stopiccot stopiccot changed the base branch from main to develop November 8, 2022 15:49
@roointan
Copy link

+1 for this

@stopiccot
Copy link
Contributor Author

Looks like it's not need when using Xcode 14.1

@stopiccot stopiccot closed this Dec 7, 2022
@stopiccot stopiccot deleted the bitcodefix branch December 7, 2022 17:00
@jkasten2
Copy link
Member

jkasten2 commented Dec 7, 2022

@stopiccot Thanks for letting us know!

@xinatcg
Copy link

xinatcg commented Mar 28, 2023

seem like this is necessary for Xcode 14+ which is enforced from 2023 April, otherwise, we need to manually set it in the post process. also need to care about the order of the post process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants