-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
virtio: Features change to 64 bit in all virtio_dispatch #616
base: main
Are you sure you want to change the base?
Conversation
change all 32 bit features to 64 bit for adapt more features Signed-off-by: Yongrong Wang <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
regarding virtio spec 64 bits could be not enough. If we update this I would be in favour of having a "features word selection index" as done in virtio mmio transport would be more reliable.
This imply to create new APIs and deprecate exiting ones...
For instance
static inline uint32_t
rpmsg_virtio_get_features_by_idx(struct rpmsg_virtio_device *rvdev, unint32 word_idx)
@arnopo Hi, from the virtio spec v1.3, the 64 bits is enough for now and linux use |
I don't know if Linux plans to do it. What I can see is that the virtio spec defines the feature bits in this way:
The virtio MMIO transport layer also supports an infinite number of feature bits So as this PR update the API i would prefer to directly address it instead of implementing an intermediate step that update the API I don't know if Linux plan to do it, what I can see is that it is that the virtio spec define the feature bits in this way:
The virtio MMIO transport layer also supports an infinite number of feature bits. So, as this PR updates the API, I would prefer to directly address it instead of implementing an intermediate step that also need an update of the API. |
@arnopo Thanks, as you said, it would be better to use "features word selection index" method to support feature bits larger than 64 bits and we will update this PR. |
This pull request has been marked as a stale pull request because it has been open (more than) 45 days with no activity. |
change all 32 bit features to 64 bit for adapt more features