Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[okhttp-gson] Make initializer block for GSON builder static #16860 #16892

Merged
merged 2 commits into from
Feb 28, 2024

Conversation

blutorange
Copy link
Contributor

Make initializer block for GSON builder static, see #16860

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
  • File the PR against the correct branch: master (upcoming 7.1.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, mention the technical committee members, so they are more likely to review the pull request.

@wing328 wing328 added this to the 7.1.0 milestone Nov 3, 2023
@wing328 wing328 modified the milestones: 7.1.0, 7.2.0 Nov 13, 2023
@wing328 wing328 removed this from the 7.2.0 milestone Dec 22, 2023
@wing328 wing328 added this to the 7.4.0 milestone Feb 28, 2024
@wing328 wing328 merged commit 8ca914d into OpenAPITools:master Feb 28, 2024
69 checks passed
@wing328
Copy link
Member

wing328 commented Feb 28, 2024

thanks for the fix, which has been merged.

sorry for taking a bit long to review as there're too many PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG][JAVA] Static Initializer Block missing in JSON support class
3 participants