[csharp] massively improve csharp templates code

[filipe-silva]

Improved apiclient.mus to keep it dry, sharing a single exec with Action<> delegate.
Improved api.mus to keep it dry, used chain constructors, kept RequestOptions in a single method, set configuration POCO with alias directive and moved fqn types to using directive for cleaner code.
Removed 'this' from variables/props that are redundant.
Fixed incompatible framework, System.Web, used on .NET 6.0 and above.

PR checklist

• Read the contribution guidelines.
• Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
• Run the following to build the project and update samples:

  ./mvnw clean package 
  ./bin/generate-samples.sh ./bin/configs/*.yaml
  ./bin/utils/export_docs_generators.sh
  

  (For Windows users, please run the script in Git BASH)
  Commit all changed files.
  This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
  These must match the expectations made by your contribution.
  You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
  IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
• File the PR against the correct branch: master (upcoming 7.1.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
• If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@mandrean @shibayan @Blackclaws @lucamazzanti @iBicha

[filipe-silva]

Added issue #16989 according to contributing readme.

[wing328]

thanks for the PR.

can you please update the tests (java unit tests) as well?

[ERROR] Failures: 
[ERROR]   CSharpClientDeepObjectTest.deepObject:70 expected:<2> but was:<1>
[ERROR] Tests run: 1997, Failures: 1, Errors: 0, Skipped: 0
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:3.0.0:test (default-test) on project openapi-generator: There are test failures.
[ERROR] 
[ERROR] Please refer to /home/circleci/OpenAPITools/openapi-generator/modules/openapi-generator/target/surefire-reports for the individual test results.
[ERROR] Please refer to dump files (if any exist) [date].dump, [date]-jvmRun[N].dump and [date].dumpstream.

ref: https://circleci.com/gh/OpenAPITools/openapi-generator/81692

[filipe-silva]

thanks for the PR.

can you please update the tests (java unit tests) as well?

[ERROR] Failures: 
[ERROR]   CSharpClientDeepObjectTest.deepObject:70 expected:<2> but was:<1>
[ERROR] Tests run: 1997, Failures: 1, Errors: 0, Skipped: 0
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:3.0.0:test (default-test) on project openapi-generator: There are test failures.
[ERROR] 
[ERROR] Please refer to /home/circleci/OpenAPITools/openapi-generator/modules/openapi-generator/target/surefire-reports for the individual test results.
[ERROR] Please refer to dump files (if any exist) [date].dump, [date]-jvmRun[N].dump and [date].dumpstream.

ref: https://circleci.com/gh/OpenAPITools/openapi-generator/81692

Sure, I can give a go, which IDE do you use?
I currently only have VSCode, but I don't use it for JAVA

[filipe-silva]

thanks for the PR.

can you please update the tests (java unit tests) as well?

[ERROR] Failures: 
[ERROR]   CSharpClientDeepObjectTest.deepObject:70 expected:<2> but was:<1>
[ERROR] Tests run: 1997, Failures: 1, Errors: 0, Skipped: 0
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:3.0.0:test (default-test) on project openapi-generator: There are test failures.
[ERROR] 
[ERROR] Please refer to /home/circleci/OpenAPITools/openapi-generator/modules/openapi-generator/target/surefire-reports for the individual test results.
[ERROR] Please refer to dump files (if any exist) [date].dump, [date]-jvmRun[N].dump and [date].dumpstream.

ref: https://circleci.com/gh/OpenAPITools/openapi-generator/81692

All done, test now run OK

[wing328]

Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors.

Let me know if you need help fixing it.

Ref: https://github.com/OpenAPITools/openapi-generator/wiki/FAQ#how-can-i-update-commits-that-are-not-linked-to-my-github-account

[filipe-silva]

Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors.

Let me know if you need help fixing it.

Ref: https://github.com/OpenAPITools/openapi-generator/wiki/FAQ#how-can-i-update-commits-that-are-not-linked-to-my-github-account

Thanks for the heads up, I think it's working. I just added a secondary email.

Btw the failing check is on the samples, it simply says:
UNCOMMITTED CHANGES ERROR
There are uncommitted changes in working tree after execution of 'bin/generate-samples.sh'

Should I run that sh locally and commit the result? Or is it something else?

[wing328]

can you please update the samples when you've time?

https://github.com/OpenAPITools/openapi-generator/actions/runs/6799047830/job/18529721203?pr=16990

update: done via b510aff

[wing328]

i've merged the latest master into your branch and filed #17097.

Some CI tests (C# related) failed. Can you please take a look when you've time?

[filipe-silva]

i've merged the latest master into your branch and filed #17097.

Some CI tests (C# related) failed. Can you please take a look when you've time?

Hi, I've regenerated the samples and everything seems to be ok, can you resolve the conflicts?

[wing328]

, can you resolve the conflicts?

please merge latest master into your branch and regenerate the samples to resolve the merge conflicts

i'll try to put other c# related PRs on hold for the time being.

[filipe-silva]

, can you resolve the conflicts?

please merge latest master into your branch and regenerate the samples to resolve the merge conflicts

i'll try to put other c# related PRs on hold for the time being.

Hi, terribly sorry, it completely slipped my mind, because of the holidays starting.

I did the pull and merge, there are no conflitcs as of now.

[wing328]

can you pls update the samples when you've time?

https://github.com/OpenAPITools/openapi-generator/actions/runs/7685681970/job/20945052863?pr=16990

[wing328]

your last commit includes changes to lots of files not originally included in this PR (likely the rebase wasn't done correctly)

can you please PM me via Slack so that I can help you out?

https://join.slack.com/t/openapi-generator/shared_invite/zt-12jxxd7p2-XUeQM~4pzsU9x~eGLQqX2g

[filipe-silva]

your last commit includes changes to lots of files not originally included in this PR (likely the rebase wasn't done correctly)

can you please PM me via Slack so that I can help you out?

https://join.slack.com/t/openapi-generator/shared_invite/zt-12jxxd7p2-XUeQM~4pzsU9x~eGLQqX2g

Hi (after a lot of time, sorry) so the rebase was getting pretty difficult at the time.
I choose another approach. I've done a new branch, up to date with master and redid my changes.
I'll be closing this PR and opening a new one, since i did a new branch.