Update base image of Dockerfile #17007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
because it won't compile with 21
as memory should be controlled by the container
|
docker CI: https://github.com/OpenAPITools/openapi-generator/actions/runs/6803432630/workflow?pr=17007 it doesn't cover everything yet. please feel free to update it with more tests in another PR when you've time. |
|
FYI @OpenAPITools/generator-core-team |
|
lgtm. let's give it a try |
jpuerto
pushed a commit
to movementsciences/openapi-generator
that referenced
this pull request
Nov 14, 2023
* Update base image of Dockerfile * Make github workflow "Docker tests" manually triggerable * Don't possibly downgrade TLS version * Update Dockerimage in ``run-in-docker.sh`` * Use Maven's non interactive mode inside workflow * Don't spam log * Use java 17 because it won't compile with 21 * Removed hard memory limit as memory should be controlled by the container * Update hub dockerfiles
|
I've filed #17076 to update Dockerfile for CLI and online service |
5 tasks
lwj5
pushed a commit
to lwj5/openapi-generator
that referenced
this pull request
Dec 5, 2023
* Update base image of Dockerfile * Make github workflow "Docker tests" manually triggerable * Don't possibly downgrade TLS version * Update Dockerimage in ``run-in-docker.sh`` * Use Maven's non interactive mode inside workflow * Don't spam log * Use java 17 because it won't compile with 21 * Removed hard memory limit as memory should be controlled by the container * Update hub dockerfiles
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17000
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming 7.1.0 minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)Remarks for reviewers:
.hub.*.dockerfileso these files may be checked manually