-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Jackson to latest v2.17.1 and sync in templates #18799
Bump Jackson to latest v2.17.1 and sync in templates #18799
Conversation
abce5bc
to
6ff50da
Compare
4436929
to
072baca
Compare
please resolve the merge conflicts when you've time. thank you |
Not required as all Jackson packages usually tether on a version bump.
072baca
to
34c7311
Compare
Ready :) |
This should have been done as part of in OpenAPITools#16853.
2f792c7
to
9e75519
Compare
Now also updated the library descriptions with version numbers (all of them) as some were completely off: Lines 238 to 252 in d2c068c
Wonder how we could ensure this doesn't get out-of-sync the next time some dependency get's updated. Probably managing all of it in a constant, such as Branch is rebased now but CI will keep failing before being rebased on #18826 |
my take is to simply omit the version number or just use 5.x instead of something of 5.1.8 as we generally don't document the library version in the description in other generators (e.g. PHP, Python, etc) |
) * Drop separate version property Not required as all Jackson packages usually tether on a version bump. * Update Jackson to v2.17.1 * Sync Jackson version used by Spring Boot with project version * Sync jackson update to v2.17.1 with generator templates * Regenerate samples with updated versions * Adjust test to current exception msg behavior * Add dependency mgmt to ensure matching version for transitive dependencies * Update library descriptions with correct Jackson version number * Update library descriptions with correct GSON and JSONB versions * Update retrofit library description with correct version number * Update retrofit description to include Jackson as an option This should have been done as part of in OpenAPITools#16853. * Update remaining libary version descriptions with correct versions * Generate updated doc
As the title says. 🔝
Also, by adjusting the Spring Boot Jackson version import, the total number of dependencies drops by 6 (to 269 for the whole project).
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master
(upcoming 7.6.0 minor release - breaking changes with fallbacks),8.0.x
(breaking changes without fallbacks)