Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kotlin-server: Fix required + nullable combination for properties #20054

Merged

Conversation

dennisameling
Copy link
Contributor

Closes #20052

Tagging the Kotlin technical committee: @dr4ke616 (2018/08) @karismann (2019/03) @Zomzog (2019/04) @andrewemery (2019/10) @4brunu (2019/11) @yutaka0m (2020/03) @stefankoppier (2022/06) @e5l (2024/10)

Before:

data class Pet(
    val notNullableRequired: kotlin.String,
    val nullableRequired: kotlin.String,
    val nullableNotRequired: kotlin.String? = null,
    val notNullableNotRequired: kotlin.String? = null
) 

After:

data class Pet(
    val notNullableRequired: kotlin.String,
    val nullableRequired: kotlin.String?,
    val nullableNotRequired: kotlin.String? = null,
    val notNullableNotRequired: kotlin.String? = null
) 

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@dennisameling
Copy link
Contributor Author

This should fix the failing Samples Kotlin server CI pipeline which is unrelated to this PR: #20061

@dennisameling dennisameling force-pushed the kotlin-server-fix-required-nullable branch from bea9c9f to 4ad6dc7 Compare November 8, 2024 13:22
@wing328
Copy link
Member

wing328 commented Nov 9, 2024

please merge the latest master into your branch when you've time.

@dennisameling dennisameling force-pushed the kotlin-server-fix-required-nullable branch from 4ad6dc7 to b139ad3 Compare November 9, 2024 11:21
@dennisameling
Copy link
Contributor Author

Done @wing328, CI is finally green now 😄 ✅

@wing328
Copy link
Member

wing328 commented Nov 9, 2024

lgtm. let's give it a try

@wing328 wing328 merged commit 13b11d7 into OpenAPITools:master Nov 9, 2024
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG][kotlin-server] required nullable properties generated incorrectly
2 participants