Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Python] Bug Fix - model_generic templates to have valid imports for polymorphism #20273

Merged
merged 3 commits into from
Jan 9, 2025

Conversation

YousefHaggy
Copy link
Contributor

@YousefHaggy YousefHaggy commented Dec 8, 2024

Fixes #20272

Can validate using the repro spec provided in the issue.

@cbornet @tomplus @krjakbrjak @fa0311 @multani

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@YousefHaggy YousefHaggy changed the title [Python] Bug Fix - model_generic python templates to have valid imports [Python] Bug Fix - model_generic templates to have valid imports for polymorphism Dec 8, 2024
@YousefHaggy
Copy link
Contributor Author

@wing328 Could you take a look at this PR? #20272 results in a completely broken generated client. Thanks!

@wing328
Copy link
Member

wing328 commented Jan 6, 2025

can you please add a test model to modules/openapi-generator/src/test/resources/3_0/python/petstore-with-fake-endpoints-models-for-testing.yaml (and then regenerate the samples twice) to cover the issue moving forward?

@YousefHaggy
Copy link
Contributor Author

@wing328 Updated with samples, thanks!

@wing328 wing328 merged commit 7a23ac7 into OpenAPITools:master Jan 9, 2025
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] [PYTHON] Invalid code generated for polymorphism when name has double underscores
2 participants