Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[normalizer] Better handling of schema with just description (any type) #20461

Merged
merged 2 commits into from
Jan 14, 2025

Conversation

wing328
Copy link
Member

@wing328 wing328 commented Jan 14, 2025

to close #20459

fyi @OpenAPITools/generator-core-team

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328 wing328 added Issue: Bug OpenAPI Normalizer Normalize the spec for easier processing labels Jan 14, 2025
@wing328 wing328 added this to the 7.11.0 milestone Jan 14, 2025
@@ -217,11 +217,11 @@ export const DefaultApiAxiosParamCreator = function (configuration?: Configurati
},
/**
*
* @param {PetsFilteredPatchRequest | null} [petsFilteredPatchRequest]
* @param {PetsFilteredPatchRequest} [petsFilteredPatchRequest]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI. This fix the incorrect null (as any type is incorrectly treated as null in openapi normalizer)

@TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @topce (2018/10) @akehir (2019/07) @petejohansonxo (2019/11) @amakhrov (2020/02) @davidgamero (2022/03) @mkusaka (2022/04) @joscha (2024/10)

@wing328 wing328 changed the title Better handling of schema with just description [normalizer] Better handling of schema with just description Jan 14, 2025
@wing328 wing328 marked this pull request as ready for review January 14, 2025 07:54
@wing328 wing328 changed the title [normalizer] Better handling of schema with just description [normalizer] Better handling of schema with just description (any type) Jan 14, 2025
@wing328 wing328 merged commit 760d5e8 into master Jan 14, 2025
18 checks passed
@wing328 wing328 deleted the fix-description-schema branch January 14, 2025 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue: Bug OpenAPI Normalizer Normalize the spec for easier processing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG][JAVA] Regression on Java webclient generation with 7.9.0
2 participants