Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: CodeGen correctly produces yyyy-mm-dd format for date with examples #20516

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Zemke
Copy link

@Zemke Zemke commented Jan 21, 2025

When an example was specified for a property with the date format, its example would be generated to something like Sat Jan 30 01:00:00 CET 2021.

It's because the resolved type for a date example is a DateSchema which uses java.util.Date to represents the date causing toString() to not conform to the yyyy-mm-dd format.

This is somewhat analogous to example generation in #17495.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant