Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply ruff format #109

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Apply ruff format #109

wants to merge 6 commits into from

Conversation

atravitz
Copy link
Contributor

ruff formatting is essentially a drop-in replacement for black: https://docs.astral.sh/ruff/faq/#is-the-ruff-linter-compatible-with-black.

@atravitz atravitz requested a review from mikemhenry January 15, 2025 19:15
@atravitz atravitz self-assigned this Jan 15, 2025
This reverts commit 694a17d.
@atravitz atravitz changed the title Apply ruff format and isort Apply ruff format Jan 15, 2025
Copy link

codecov bot commented Jan 15, 2025

Codecov Report

Attention: Patch coverage is 90.98361% with 11 lines in your changes missing coverage. Please review.

Project coverage is 87.78%. Comparing base (542652a) to head (efa1d0c).

Files with missing lines Patch % Lines
...work_planners/concatenators/cyclic_concatenator.py 0.00% 2 Missing ⚠️
..._planners/generators/explicit_network_generator.py 50.00% 2 Missing ⚠️
src/konnektor/network_analysis/network_analysis.py 83.33% 1 Missing ⚠️
src/konnektor/network_planners/NetworkPlanner.py 66.66% 1 Missing ⚠️
...planners/generators/clustered_network_generator.py 85.71% 1 Missing ⚠️
...erators/minimal_spanning_tree_network_generator.py 66.66% 1 Missing ⚠️
...work_planners/generators/star_network_generator.py 75.00% 1 Missing ⚠️
...c/konnektor/network_tools/network_handling/misc.py 0.00% 1 Missing ⚠️
src/konnektor/utils/optional_import.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #109      +/-   ##
==========================================
+ Coverage   87.74%   87.78%   +0.03%     
==========================================
  Files          49       49              
  Lines        1559     1547      -12     
==========================================
- Hits         1368     1358      -10     
+ Misses        191      189       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

)

from . import network_analysis
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I deleted this because, if moved to the top, it causes circular imports. I don't think it's actually needed, but please correct me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant