Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimum package support 0A15 (PACKET_ZC_GOLDPCCAFE_POINT) #3916

Merged
merged 1 commit into from
Dec 25, 2024

Conversation

ya4ept
Copy link
Contributor

@ya4ept ya4ept commented Dec 24, 2024

This query solves the problem: #3907

<< Received packet:      0A15 [12 bytes]   2024.12.17 09:12:57
  0>  15 0A 01 01 35 00 00 00    AF 00 00 00                ....5.......
[2024.12.17 09:12:57.41] Packet Parser: Unknown switch: 0A15

#if PACKETVER >= 20140611
struct PACKET_ZC_GOLDPCCAFE_POINT {
	// Note: 2014-04-30 has 1 byte less, but those packets are only functional after 2014-06-11Ragexe
	uint16 PacketType;
	int8 isActive; //< 1 = yes, 0 = no
	int8 mode;
	int32 point;
	int32 playedTime;
} __attribute__((packed));
DEFINE_PACKET_HEADER(ZC_GOLDPCCAFE_POINT , 0x0a15);
#endif // PACKETVER >= 20140611

If you get the error "Received unknown packet", just add a new packet to therecvpackets.txt file:

0A15 12

I haven't tested this functionality!

rathena/rathena#7410
https://rathena.org/board/topic/139548-goldpc-shop/
image

@ya4ept
Copy link
Contributor Author

ya4ept commented Dec 24, 2024

@dcyxxt Can you test this?

@ya4ept ya4ept mentioned this pull request Dec 24, 2024
@dcyxxt
Copy link

dcyxxt commented Dec 25, 2024

@dcyxxt Can you test this?

I'd love to test it, but the server I'm playing on doesn't have this NPC, and I don't get this packet error

@ya4ept
Copy link
Contributor Author

ya4ept commented Dec 25, 2024

@dcyxxt very strange, I found this error in your log: #3905

[2024.12.17 09:12:57.41] Packet Parser: Unknown switch: 0A15
<< Received unknown switch [12 bytes] 2024.12.17 09:12:57

@ya4ept
Copy link
Contributor Author

ya4ept commented Dec 25, 2024

@kidultwoo already tested

@alisonrag let's merge

@dcyxxt
Copy link

dcyxxt commented Dec 25, 2024

@dcyxxt very strange, I found this error in your log: #3905

[2024.12.17 09:12:57.41] Packet Parser: Unknown switch: 0A15
<< Received unknown switch [12 bytes] 2024.12.17 09:12:57

oho~~i didnt realized it before,but thx

@ya4ept ya4ept merged commit b10b2f2 into master Dec 25, 2024
9 checks passed
@ya4ept ya4ept deleted the add_0A15_packet branch December 25, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants