builder: implement orientation according to coordinates #66

Tristramg · 2024-09-26T17:09:30Z

This should be a pretty common problem for any user of the library, so it makes sens to have this in the library

This allowed to find an bug, hence the first tests in the builder (ref. #57)

Signed-off-by: Tristram Gräbener <[email protected]>

Castavo

Looks neat
I have to proof-read the tests and run them

How about also a

pub fn orient_along_other_traversals(
    &mut self,
    traversal_index: usize,
    other_traversal_indexes: &[usize]
)

Castavo

The tests run
I have a few comment but it's nitpicking

src/builder.rs

builder: more coherent test Co-authored-by: Baptiste Prévot <[email protected]>

Tristramg added 2 commits September 26, 2024 14:39

builder: bugfix adding the nodes on a traversal

4d8d133

Signed-off-by: Tristram Gräbener <[email protected]>

builder: add a function to orient a traversal according to two points

47161d1

Signed-off-by: Tristram Gräbener <[email protected]>

Tristramg requested review from woshilapin and Castavo September 26, 2024 17:09

Castavo reviewed Sep 27, 2024

View reviewed changes

Castavo approved these changes Sep 27, 2024

View reviewed changes

src/builder.rs Show resolved Hide resolved

src/builder.rs Outdated Show resolved Hide resolved

src/builder.rs Show resolved Hide resolved

Apply suggestions from code review

7b1247e

builder: more coherent test Co-authored-by: Baptiste Prévot <[email protected]>

Tristramg merged commit b25b812 into main Sep 29, 2024
8 checks passed

Tristramg deleted the changes_for_dags branch December 1, 2024 13:25

Provide feedback