-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
front: delete infra at the end of e2e-tests #10518
base: dev
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #10518 +/- ##
==========================================
+ Coverage 81.78% 81.80% +0.02%
==========================================
Files 1073 1073
Lines 106577 106718 +141
Branches 731 730 -1
==========================================
+ Hits 87162 87303 +141
Misses 19376 19376
Partials 39 39
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems ok (and obvious) for me, I didn't even notice this disappeared until now, I wait for @Maymanaf to know why this is missing
The infrastructure is used for STDCM tests, so it cannot be deleted, and the teardown will always fail |
Thanks! I had renamed all the infras in my db, so the setup and teardown were working fine for me. I did notice I had an undeletable infra because it was used in an stdcmsearchcontext. Do you know when this is used, and whether we could define and destroy it each time? Right now the tests are dependent on a specific state of the database, which make them more brittle. I would rather minimize such dependence if possible. |
The issue lies in the backend implementation. Currently, there is no dedicated endpoint available for deleting the |
Thanks, I'll look into it |
Close #10517
Feel free to refuse the PR if there is a very good reason not to delete the infra