Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RCM-DX-Specification_EN.md #31

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Jean-FredericBonjour
Copy link
Contributor

Hi RCM-DX,
I propose to add new consistencytype WARNING & EXCLUDED Please review.
Cheers Jean-Frédéric

Hi RCM-DX,
I propose to add new consistencytype WARNING & EXCLUDED
Please review.
Cheers Jean-Frédéric
@schalbts
Copy link
Contributor

Question about "excluded": The data has been excluded from the consistency check?
How has the data been verified?

And
maybe we can change the wording to make the paragraph more consistent (was/has been)?

Name Description
CONSISTENT The referenced data has been checked and is consistent
INCONSISTENT The referenced data has been checked and is inconsistent
WARNING The referenced data has been checked and set to warning (undefined: orange)
EXCLUDED The referenced data has been verified, but is defined as to be exluded from the consistency
NO_DATA Consistency has been checked, but no data was found

@Jean-FredericBonjour
Copy link
Contributor Author

Hi Stephanie,
Thanks for checking my change request and for your answer. Of course "was" can be replaced by "has been".

Unfortunately, it's impossible for me to change my own pull request. Either you can reject this current pull request and I will do another one or you do the modification by yourself.

Here below in bold the proposed changes. I changed the definition of EXCLUDED to be more precise

Name Description
CONSISTENT The referenced data has been checked and is consistent (OK: green)
INCONSISTENT The referenced data has been checked and is inconsistent (not OK: red)
WARNING The referenced data has been checked and set to warning (undefined: orange)
EXCLUDED The referenced data has been checked for consistency and is defined to be flagged as excluded.
NO_DATA Consistency has been checked, but no data was found

Cheers Jean-Frédéric

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants