Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webs.com has shutdown #3772

Merged
merged 5 commits into from
Jan 12, 2025
Merged

Conversation

Bellangelo
Copy link
Contributor

@Bellangelo Bellangelo commented Dec 19, 2024

Closes #1150

webs.com has shutdown so i moved all the contents into its history file and then clean them up.

@MattiSG MattiSG requested a review from Cli4d December 19, 2024 13:22
Copy link
Member

@Cli4d Cli4d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there,

Thank you for your contribution regarding the termination of this service, as it is no longer being offered. After reviewing your submission, I have a few things to seek clarification on

  1. I noticed that you deleted the Webs.json file to stop the tracking. However, the documentation states that one only needs to clear the terms type from the document.

  2. I am also unsure if the history.json file can include properties such as name, imported from, and documents property for the terms types.

I will seek guidance from @OpenTermsArchive/core regarding these issues. Once everything is confirmed, I will proceed to merge this pull request.

Thank you for your contribution!

@MattiSG
Copy link
Member

MattiSG commented Jan 3, 2025

Indeed @Cli4d, the Webs.json declaration should keep the name and importedFrom metadata, while the history file should contain only the documents property 🙂

@Bellangelo
Copy link
Contributor Author

Indeed @Cli4d, the Webs.json declaration should keep the name and importedFrom metadata, while the history file should contain only the documents property 🙂

Thanks a lot @MattiSG for your feedback. I have made the necessary changes.

@Bellangelo Bellangelo requested a review from Cli4d January 3, 2025 17:13
Copy link
Member

@Cli4d Cli4d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Bellangelo,

Thank you for making the requested changes. I have reviewed the pull request, and everything looks good to me. I will proceed to merge it.

I appreciate your contribution in terminating this service and your responsiveness in implementing the changes.

Thank you!

@Cli4d Cli4d merged commit 2ee1883 into OpenTermsArchive:main Jan 12, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WebsPrivacy Policy ‧ not tracked anymore
3 participants