Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gov achievements test #260

Open
wants to merge 32 commits into
base: main
Choose a base branch
from
Open

Gov achievements test #260

wants to merge 32 commits into from

Conversation

nattjn
Copy link
Collaborator

@nattjn nattjn commented Jul 14, 2023

Why this PR

Why we need this PR? For crawl_gov_achivements test cases

Changes

  • Add test cases for 2 additional functions and fix the previous error

Related Issues

Close #

Checklist

  • PR should be in the Naming convention
  • Assign yourself in to Assigneees
  • Tag related issues
  • Constants name should be ALL_CAPITAL, function name should be snake_case, and class name should be CamelCase
  • complex function/algorithm should have Docstring
  • 1 PR should not have more than 200 lines changes (Exception for test files). If more than that please open multiple PRs
  • At least PR reviewer must come from the task's team (model, eval, data)

Nattarika and others added 20 commits July 3, 2023 22:09
test
52ecf42
Add .py
69ce172
@nattjn
Modify get_title_date and change some variables to CONST
cc8b3f5
@nattjn
Modify functions get_title_date and get_info
cb824a0
@nattjn
Modify time sleep and text_response
8500408
@nattjn
remove CONST TOP_STORIES_URL and add it to script instead
093914c
@nattjn
Crawl top news from MFA and save as CSV
fd9f7f7
@nattjn
Edit import
8a1b490
@nattjn
Modify process_title_date so it can be used for all mfa news
81625f6
@nattjn
Change file name and create a new one to crawl government achievements
64aed5a
@nattjn
Modify import for top_news and add a new script to crawl mfa gov_achi…
57c781b 
…evements
@nattjn
Add script to crawl press release
a417dce
@nattjn
Add scripts to crawl press release, embassy and consulate and other news
9ca1cee
@nattjn
Add time delay as an argument (Done)
4397688
@nattjn
Add test cases for crawl_gov_achievements
a023155
@nattjn
Correct the function used for test cases [Done, ready for review]
45ac726
@nattjn
Edit test function's name
8afcf8d
@nattjn
Delete crawl_news.py
fdbbf4d
@nattjn
Seperate the inside content to 2 additional functions
cd8e3bc
@nattjn
Fix test cases
d509673
@nattjn
Copy link
Collaborator Author

nattjn commented Jul 14, 2023

all done

@boat1603
Copy link
Collaborator

@nattjn Why you removed these files?

@nattjn
Copy link
Collaborator Author

nattjn commented Jul 17, 2023

@boat1603 I didn't realize it added all the files I modified even though I only added 1 file

@nattjn
Copy link
Collaborator Author

nattjn commented Jul 18, 2023

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArthurMinovsky ArthurMinovsky ArthurMinovsky approved these changes

@boat1603 boat1603 boat1603 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nattjn @boat1603 @ArthurMinovsky