Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated logging in PlaybackThread queue handling #39

Merged
merged 1 commit into from
Oct 27, 2023
Merged

Conversation

NeonDaniel
Copy link
Member

Prevent empty logging of queue.Empty exceptions
Update exceptions to log error instead of DEBUG since empty queue is explicitly handled

Update exceptions to log error instead of DEBUG since empty queue is explicitly handled
@NeonDaniel NeonDaniel requested a review from a team October 27, 2023 20:45
@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (dev@e8b3743). Click here to learn what that means.

Additional details and impacted files
@@          Coverage Diff          @@
##             dev     #39   +/-   ##
=====================================
  Coverage       ?   0.00%           
=====================================
  Files          ?       8           
  Lines          ?     932           
  Branches       ?       0           
=====================================
  Hits           ?       0           
  Misses         ?     932           
  Partials       ?       0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@NeonDaniel NeonDaniel marked this pull request as draft October 27, 2023 20:46
@NeonDaniel NeonDaniel marked this pull request as ready for review October 27, 2023 20:52
@JarbasAl JarbasAl merged commit c4bbcf7 into dev Oct 27, 2023
5 checks passed
@JarbasAl JarbasAl deleted the LOG_CleanupLogging branch October 27, 2023 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants