Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:runtime_lang #165

Merged
merged 2 commits into from
Jan 16, 2025
Merged

fix:runtime_lang #165

merged 2 commits into from
Jan 16, 2025

Conversation

JarbasAl
Copy link
Member

@JarbasAl JarbasAl commented Jan 16, 2025

Summary by CodeRabbit

  • New Features

    • Enhanced language support for speech-to-text transcription.
    • Improved debug logging for transcription processes.
  • Bug Fixes

    • Ensured correct language context is applied during speech-to-text conversion.
    • Enhanced error logging for transcription attempts.
  • Chores

    • Added additional logging for better diagnostic capabilities.

Copy link
Contributor

coderabbitai bot commented Jan 16, 2025

Walkthrough

The pull request introduces language-specific enhancements to the speech-to-text (STT) processing in the OVOS Dinkum Listener. Changes are focused on two files: plugins.py and voice_loop.py. The modifications add debug logging for language tracking in the FakeStreamingSTT class and improve language handling during transcription in the DinkumVoiceLoop class, ensuring that the specified language is explicitly used when converting speech to text.

Changes

File Change Summary
ovos_dinkum_listener/plugins.py Added debug logging to FakeStreamingSTT.transcribe() method to log the current language during transcription.
ovos_dinkum_listener/voice_loop/voice_loop.py Updated _get_tx method to explicitly handle language by extracting lang from STT object and passing it to transcription methods; improved error handling with specific exception logging.

Sequence Diagram

sequenceDiagram
    participant VoiceLoop
    participant STT
    participant FallbackSTT

    VoiceLoop->>STT: Get language
    STT-->>VoiceLoop: Return language
    VoiceLoop->>STT: Transcribe(lang=language)
    STT-->>VoiceLoop: Transcription result
    alt Transcription fails
        VoiceLoop->>FallbackSTT: Transcribe(lang=language)
        FallbackSTT-->>VoiceLoop: Fallback transcription
    end
Loading

Poem

🐰 A Rabbit's Ode to Language Delight

In bytes of sound, a whisper's might,
With language tagged, we transcribe right,
Debug logs dancing, clear and bright,
Our listener learns with pure delight!

🎤✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 88ca19d and 67cb740.

📒 Files selected for processing (1)
  • ovos_dinkum_listener/voice_loop/voice_loop.py (2 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • ovos_dinkum_listener/voice_loop/voice_loop.py
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: install (3.11)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added fix and removed fix labels Jan 16, 2025
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 61dcdd5 and 88ca19d.

📒 Files selected for processing (2)
  • ovos_dinkum_listener/plugins.py (1 hunks)
  • ovos_dinkum_listener/voice_loop/voice_loop.py (2 hunks)
🧰 Additional context used
🪛 Ruff (0.8.2)
ovos_dinkum_listener/voice_loop/voice_loop.py

716-716: Do not use bare except

(E722)

⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: install (3.11)
🔇 Additional comments (2)
ovos_dinkum_listener/plugins.py (1)

77-77: LGTM! Good addition of debug logging.

The debug logging statement helps track which language is being used during transcription, improving observability of the STT process.

ovos_dinkum_listener/voice_loop/voice_loop.py (1)

Line range hint 703-711: LGTM: Language handling implementation looks good!

The code correctly handles language detection and validation, ensuring proper language context is maintained across STT streams.

ovos_dinkum_listener/voice_loop/voice_loop.py Outdated Show resolved Hide resolved
ovos_dinkum_listener/voice_loop/voice_loop.py Outdated Show resolved Hide resolved
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
@github-actions github-actions bot added fix and removed fix labels Jan 16, 2025
@JarbasAl JarbasAl merged commit dc7e79d into dev Jan 16, 2025
9 checks passed
@JarbasAl JarbasAl deleted the fix/runtime_lang branch January 16, 2025 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant