gtk+3: Fix incorrect PACKAGECONFIG override #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Overridding PACKAGECONFIGs with PACKAGECONFIG_remove for a different package than the current context requires the spelling PACKAGECONFIG_pn-packagename (where packagename is replaced with the packagename, but pn is a literal pn). The gtk+3 bbappend uses PACKAGECONFIG_remove_imxgpu2d when it should be PACKAGECONFIG_remove_pn-imxgpu2d, which makes the remove apply to the recipe this is appended to (gtk+3 from openembedded-core), which breaks gtk+3 when both wayland and x11 are in your distro features as they are when requesting x11 backcompat for wayland. It also makes the remove not actually apply to imxgpu2d. Fixing the spelling here fixes both issues.
sotaoverride
approved these changes
Aug 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overridding PACKAGECONFIGs with PACKAGECONFIG_remove for a
different package than the current context requires the spelling
PACKAGECONFIG_pn-packagename (where packagename is replaced with
the packagename, but pn is a literal pn). The gtk+3 bbappend
uses PACKAGECONFIG_remove_imxgpu2d when it should be
PACKAGECONFIG_remove_pn-imxgpu2d, which makes the remove apply
to the recipe this is appended to (gtk+3 from openembedded-core),
which breaks gtk+3 when both wayland and x11 are in your distro
features as they are when requesting x11 backcompat for wayland.
It also makes the remove not actually apply to imxgpu2d.
Fixing the spelling here fixes both issues.