Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SHARED:YKI:AKR(Frontend): OPHYKIKEH-311 Update CookieBanner to be non-modal #606

Merged
merged 3 commits into from
Dec 1, 2023

Conversation

lket
Copy link
Contributor

@lket lket commented Nov 24, 2023

Yhteenveto

Toteutuksen yhteenveto...

Lisätiedot

Tehdyt muutokset...

Huomautukset

Muut mahdolliset huomautukset...

Check-lista

  • yarn.lock päivitetty
  • Käännösten Excel-tiedosto päivitetty
  • UI-muutoksia testattu eri selaimilla ja mobiilinäkymässä

@lket lket force-pushed the feature/OPHYKIKEH-311v2 branch from 179d823 to 1b8a59a Compare November 28, 2023 09:29
@lket lket force-pushed the feature/OPHYKIKEH-311v2 branch from 1b8a59a to c408d77 Compare November 28, 2023 09:42
@lket lket force-pushed the feature/OPHYKIKEH-311v2 branch from c408d77 to 3391fe6 Compare November 28, 2023 13:08
@lket lket marked this pull request as ready for review November 28, 2023 14:15
Comment on lines +45 to 47
if (!open) return null;

return (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (!open) return null;
return (
return open && (

Ei merkitystä toiminnallisuuteen mutta tää ois ehkä enemmän se tyyli mitä Reactin kans käytetty.

Copy link
Contributor

@jrkkp jrkkp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testailin YKIn ja AKRn läpi Safarilla ja VoiceOverilla. En löytäny ongelmia eli eiköhän tän voine mergeillä.

@lket lket merged commit 7ec66ee into dev Dec 1, 2023
8 checks passed
@lket lket deleted the feature/OPHYKIKEH-311v2 branch December 1, 2023 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants