VKT(Frontend): OPHKIOS-92 UI-parannuksia #693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkoivisto
force-pushed
the
feature/OPHKIOS-92
branch
5 times, most recently
from
502374c to
f4ead59
Compare
pkoivisto
force-pushed
the
feature/OPHKIOS-92
branch
3 times, most recently
from
dc02ac4 to
96d5f3a
Compare
|
Testailin tätä pallerolla joten en ole ihan varma onko nämä tästä johtuvia glitchejä, mutta lokaalisti hankala luurilla testata. Kaikki vaikuttas toimivan, mut jotain leiskaan liittyviä pikku juttuja sattui silmään. 
|
pkoivisto
force-pushed
the
feature/OPHKIOS-92
branch
from
61511e7 to
e92ce69
Compare
Koitin vähän fiksailla näitä kauneusvirheitä. Huomasin myös että mobiililla tuo esikatselunäkymä oli aika lailla erilainen kuin Figmassa, erityisesti noiden valittujen tutkintojen ja osakokeiden osalta, joten muokkasin sitä osuutta vielä uusiksi. |
…ils to same step as other contact details [deploy]
… the FileUpload component
…dress details together with other contact details [deploy]
…re padding as a hack [deploy]
Instant.now() may set time with nanosecond precision, depending on platform. At least the Localstack S3 implementation requires pre-signed url expiration timestamp precision be six null-padded microsecond digits. Overwriting expiration timestamp microsecond part to 000001 fixes this problem. Localstack implementation is: POLICY_EXPIRATION_FORMAT2 = "%Y-%m-%dT%H:%M:%S.%fZ" https://github.com/localstack/localstack/blob/0b4846bc9b28247a2156fce40fcdd61da74b9d76/localstack-core/localstack/services/s3/presigned_url.py#L87
…r match designs [deploy]
pkoivisto
force-pushed
the
feature/OPHKIOS-92
branch
from
25bf158 to
2554b41
Compare
jrkkp
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.