VKT(Frontend & Backend): OPHKIOS-102 Tieto kaikista KOSKI-tutkinnoista virkailijalle #697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkoivisto
force-pushed
the
feature/OPHKIOS-102
branch
2 times, most recently
from
c320b7b to
50dcaab
Compare
pkoivisto
changed the title
jrkkp
reviewed
Sep 9, 2024
jrkkp
reviewed
Sep 9, 2024
| return DIA; | ||
| } else if (educationType.equals(KoulutusTyyppi.EB.toString())) { | ||
| return EB; | ||
| } else return None; |
There was a problem hiding this comment.
En oo varma oonko ymmärtäny tän oikein mutta pitäiskö tässä olla Other?
There was a problem hiding this comment.
Joo, varmastikin. En tosin oo ihan varma mitä nää muut koulutustyypit saattoi olla.
jrkkp
approved these changes
Sep 11, 2024
…unted in the free enrollment quota
…ed or if invoked separately through clerk APIs
… a DTO instead of a model [deploy]
pkoivisto
force-pushed
the
feature/OPHKIOS-102
branch
from
225678c to
651771a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.