feat: add opentelemetry support (but no instrumentation yet) #667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
wolverian
force-pushed
the
feat/otel-too
branch
from
d76e495 to
26aa67a
Compare
| { | ||
| "customType": "regex", | ||
| "fileMatch": ["\\.ts$"], | ||
| "matchStrings": [ |
There was a problem hiding this comment.
Mitä tämä tekee? Onko vaikutusta e2e:hen?
There was a problem hiding this comment.
Tätä käytetään kohdassa https://github.com/Opetushallitus/koto-rekisteri/pull/667/files#diff-c2bc29222885a24f378713b86c792524289f18d9a645a40b8490345da9d09f82R141 - kerrotaan renovatelle että seuraavalla rivillä on riippuvuus ja miten sen voi parsia ja päivittää. Ei vaikuta e2e:hen ellei sinne lisää samantyylistä kommenttia.
There was a problem hiding this comment.
...ja tuo tosiaan tarvitaan koska tämä otel-sidecar-kontti on uusi tässä PR:ssä ja sen versio määritellään meidän CDK-koodissa.
saku-koodari
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.