Skip to content

Commit

Permalink
Functionality for SAML RBAC and RBAC in Spinnaker (#195)
Browse files Browse the repository at this point in the history
* Fix changes for SAML support, tested with OKTA

* Changed gate, sapor and platform CM to secret

* Added a flag to disable sampleapp autoinstall, for use in upgrades

* Added flag for RBAC in spinnaker

* Bump chart version

Co-authored-by: Abhinay Byrisetty <[email protected]>
  • Loading branch information
ksrinimba and abhinaybyrisetty authored Sep 20, 2021
1 parent d9e68db commit 6459832
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 2 deletions.
2 changes: 1 addition & 1 deletion charts/oes/Chart.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
apiVersion: v2
name: oes
version: 3.9.4
version: 3.9.5
appVersion: 3.9.1.2
description: OES is a non-forked version of OSS spinnaker
icon: https://raw.githubusercontent.com/OpsMx/enterprise-spinnaker/master/img/opsmx.png
Expand Down
9 changes: 9 additions & 0 deletions charts/oes/config/oes-gate/gate.yml
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,11 @@ services:
host: 0.0.0.0
port: 7003
baseUrl: http://spin-fiat:7003
{{- if .Values.global.commonGate.spinnakerRBAC }}
enabled: true
{{- else }}
enabled: false
{{- end }}
front50:
host: 0.0.0.0
port: 8080
Expand Down Expand Up @@ -136,6 +140,11 @@ ldap:
managerPassword: {{ .Values.global.ldap.managerPassword }}
{{- end }}
{{- if .Values.gate.config.saml.enabled }}
security:
basic:
enabled: true
user: {}

saml:
{{ toYaml .Values.gate.config.saml | indent 2 }}
{{- end }}
Expand Down
3 changes: 2 additions & 1 deletion charts/oes/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@ global:
# common gate for both spin and oes
commonGate:
enabled: true
spinnakerRBAC: false

customCerts:
enabled: false
Expand Down Expand Up @@ -421,7 +422,7 @@ gate:
# kubectl create secret generic oessamljks --from-file=oessaml.jks
# kubectl create secret generic samljks-password --from-literal password=changeit
saml:
enabled: true
enabled: false
userSource: gate # Groups will be obtained from SAML
keyStore: /opt/spinnaker/saml/oessaml.jks # The key in this secret must be oessaml.jks
keyStorePassword: changeit
Expand Down

0 comments on commit 6459832

Please sign in to comment.