Upgrading halyard-oes from OES-1.30.X to OES-1.33.X -v1.65 #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: root <root@447a079020df>
Co-authored-by: root <root@d357836a74e2>
…ases over junit5 in halyard (spinnaker#2022) Spring boot 2.4.x removed JUnit5 vintage engine from spring-boot-starter-test. [https://github.com/spring-projects/spring-boot/wiki/Spring-Boot-2.4-Release-Notes#junit-5s-vintage-engine-removed-from-spring-boot-starter-test] It is required for executing junit4 based test cases in halyard. So, introducing junit-vintage-engine dependency in build.gradle, using testRuntimeOnly() as suggested in section 3.1 of https://junit.org/junit5/docs/5.6.2/user-guide/index.pdf After applying this fix, coverage increased from 54 to 227 test case executions.
Co-authored-by: root <root@ddd9a40eca8a>
Co-authored-by: root <root@c4be0877baae>
Co-authored-by: root <root@678a4f9afbf2>
Co-authored-by: root <root@97cff56e1889>
Co-authored-by: root <root@0410400d9ceb> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: root <root@09edb544a130>
Co-authored-by: root <root@ca4d9d1417e6>
Co-authored-by: root <root@1087c434d482>
Co-authored-by: root <root@a7f63fd249e6>
…innaker#2035) see spinnaker/spin@7fa1646 Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 2 to 4. - [Release notes](https://github.com/docker/build-push-action/releases) - [Commits](docker/build-push-action@v2...v4) --- updated-dependencies: - dependency-name: docker/build-push-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [actions/setup-java](https://github.com/actions/setup-java) from 2 to 3. - [Release notes](https://github.com/actions/setup-java/releases) - [Commits](actions/setup-java@v2...v3) --- updated-dependencies: - dependency-name: actions/setup-java dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [actions/checkout](https://github.com/actions/checkout) from 2 to 3. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v2...v3) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…iles (spinnaker#2039) to avoid warning messages like Run echo ::set-output name=REPO::${GITHUB_REPOSITORY##*/} Warning: The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/ Warning: The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Co-authored-by: root <root@6df01364f536>
Co-authored-by: root <root@3e028cce7c94>
Co-authored-by: root <root@9719ce3424b9>
Co-authored-by: root <root@0655c5db933b>
Co-authored-by: root <root@63d86d5636ba>
Co-authored-by: root <root@daa08b560ddd>
Co-authored-by: root <root@f1cbd44bf3d1>
Co-authored-by: root <root@c4ba54b4ec41>
Co-authored-by: root <root@829b5b3a21f9>
Co-authored-by: root <root@32dad1157ef7>
Co-authored-by: root <root@636fee72d08c> Co-authored-by: Cameron Motevasselani <[email protected]>
… python-pip3 install with manual install of AWS_CLI (#13) * fix(halyard):Update Dockerfile for python-pkg trivy cves fix- replace python-pip3 install with manual install of AWS_CLI * fix(halyard):Update Dockerfile for python-pkg trivy cves fix- replace python-pip3 install with manual install of AWS_CLI
…ogle.guava:guava:32.1.1-jre for weekly cve report
updating github actions with image format
…mmited changes for GitHubWorkflows and gradle.properties
…3.x' into feature/OP-22255-OES-upgrade-1.33.x
| #echo ::set-output name=VERSION::"1.55.1$(date --utc +'%Y%m%d')" | ||
| #echo ::set-output name=VERSION::"1.55.1$(date --utc +'%-m%d')" | ||
| echo ::set-output name=VERSION::"1.55.1" | ||
| #echo ::set-output name=VERSION::"1.65.0$(date --utc +'%Y%m%d%H%M')" |
There was a problem hiding this comment.
Suggestion : instead of tag, can we use branchName i.e. 1.33.x ? Applicable elsewhere.
There was a problem hiding this comment.
For halyard as we were using version based,so kept it as like before.
|
gradle files - LGTM |
aman-agrawal
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://devopsmx.atlassian.net/browse/OP-22085 : ParentJira
https://devopsmx.atlassian.net/browse/OP-22255 : JIra
Testing:
Compile/Build got success, All TestCases passed, No new TestCases failed.
halyard-core:test - Results: SUCCESS (57 tests, 57 successes, 0 failures, 0 skipped)
halyard-deploy:test - Results: SUCCESS (37 tests, 37 successes, 0 failures, 0 skipped)
halyard-config:test - Results: SUCCESS (122 tests, 122 successes, 0 failures, 0 skipped)
halyard-cli:test - Results: SUCCESS (86 tests, 86 successes, 0 failures, 0 skipped)
Tested Locally: Halyard Instance is UP and Application running running successfully
Note :
Commits verified from v1.65 spinnaker/halyard - https://github.com/spinnaker/halyard/commits/v1.65.0/
SNAPSHOT versions usedfor clouddriverVersion, fiatVersion, korkVersion, front50Version are 1.33.0-SNAPSHOT, if any updation in SNAPSHOT version, will be pushed in next PR