[issue-229] do not persist legacy property-backed-beans from legacy propertybackedbeans on init #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AFaust
requested changes
Nov 20, 2024
There was a problem hiding this comment.
The only remark I would have is to adhere to the style guide with regards to opening braces.
…ropertybackedbeans on init This fix prevents property-backed-beans configuration being persisted at init. This mitigates issues where breaking configuration is duplicated in the database, ensuring that simple removal of the broken configuration allows for startup.
RVanhuysseXenit
force-pushed
the
issue-229
branch
from
d0155a0 to
ea8fb9b
Compare
|
My bad. I've fixed it up. |
AFaust
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHECKLIST
We will not consider a PR until the following items are checked off--thank you!
CONVINCING DESCRIPTION
This fix prevents property-backed-beans configuration being persisted at init. This mitigates issues where breaking configuration is duplicated in the database, ensuring that simple removal of the broken configuration allows for startup.
RELATED INFORMATION
... If you have any supporting material such as issues that are addressed by this
PR, links outlining any special techniques or libraries used, etc that will help
us to evaluate this PR. Please include that information here...
Fixes #229
BE WARNED
When we decline or close your PR. You are encouraged to address the concerns outlined in the
PR and then re-submit it. We want contributions. We also need for them to be of high quality
and high value and to not take undue resources away from the features and enhancements the
core team is working on. Thanks for understanding!