Update Docker image #339
Merged
Update Docker image #339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should reduce the number of layers in the final image.
The "googletest" source package contains both Google Test and Google Mock, though the binary packages are split.
There's been some package shuffling for the Google Test library. Previously the "libgtest-dev" package had source code, with no compiled library binary. Projects would compile the library from source, using compile flags that matched the project. Now there is a "googletest" package for the source, and "libgtest-dev" and "libgmock-dev" contain compiled library binaries. We are now using the compiled binary packages, even though those package names used to refer to source packages.
DanRStevens
force-pushed
the
updateDockerImage
branch
from
affa56e to
5a2e28c
Compare
|
Merging in #341 to master and rebased on that to avoid test failures, hence the forced push. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the Docker image for CircleCI builds.
The change allows deprecation warnings to be seen for the newer version of Google Test.
The update also reveals some path handling changes related to the
<filesystem>header. (Edit: See #340, and #341).