Feature/multi line tool tip #1473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanRStevens
reviewed
Dec 12, 2024
There was a problem hiding this comment.
Thinking about the impact to the API of this change. Do we want to use a std::vector of strings, or do we want to support strings with embedded newlines? I'd be tempted to consider strings with embedded newlines. Seems like a more natural API to use. Particularly since sources of multi-line input may come with naturally embedded newlines.
oscar139
force-pushed
the
Feature/Multi-line-tool-tip
branch
2 times, most recently
from
f3d5c6e to
02dfa90
Compare
DanRStevens
reviewed
Dec 21, 2024
|
This might be of interest to a couple of those comments: // read file line by line
std::istringstream input;
input.str("1\n2\n3\n4\n5\n6\n7\n");
int sum = 0;
for (std::string line; std::getline(input, line);)
sum += std::stoi(line);
std::cout << "\nThe sum is " << sum << ".\n\n";The use of the |
oscar139
force-pushed
the
Feature/Multi-line-tool-tip
branch
from
02dfa90 to
61bc8bd
Compare
DanRStevens
reviewed
Dec 21, 2024
oscar139
force-pushed
the
Feature/Multi-line-tool-tip
branch
5 times, most recently
from
c88d306 to
ecd45f6
Compare
DanRStevens
approved these changes
Dec 24, 2024
DanRStevens
force-pushed
the
Feature/Multi-line-tool-tip
branch
from
ecd45f6 to
edff544
Compare
oscar139
force-pushed
the
Feature/Multi-line-tool-tip
branch
from
edff544 to
fd8bdd2
Compare
DanRStevens
approved these changes
Dec 27, 2024
Comment on lines
+135
to
+138
| forEachLine(mFocusedControl->second, [this, &renderer, &linePosition](const std::string& lineStr) { | ||
| renderer.drawText(mFont, lineStr, linePosition); | ||
| linePosition.y += mFont.height(); | ||
| }); |
There was a problem hiding this comment.
It's also possible to do a named capture, as an alternative to capturing this, and everything that has access to:
[&font=mFont, &renderer, &linePosition]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes allow the Tool Tip Class to support tool-tips with multiple lines.