Improve and fix vcpkg caching
#1493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous copy command was copying the contents of the first folder into the second folder. That effectively stripped off the root folder name from the source, losing one level of folders. That of course made the copy rather useless, which meant no time was saved when trying to build the NAS2D project.
Hopefully this separates out the setup time from the later build steps, without increasing overall build time in any significant way.
This should prevent the need to start from scratch after a failed build.
Since packages are cached in separate folders between NAS2D and OPHD, we should probably run-the pre-install step for both of them.
Since we are explicitly saving the cache after the NAS2D build, we should make the restore specifically a restore, and not a fully wrapped restore + save as a post step.
Makes more sense to group these together. Less that can go wrong in the middle and prevent the NAS2D build cache from being saved.
This was referenced Jan 10, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split
vcpkg installof dependencies into it's own step. This separates the timing for thevcpkgstep from the build step.Fix copying of
vcpkg_installedfolders from OPHD to NAS2D.Turns out there isn't a serious doubling of time for
vcpkginitialization when it's split out like this. Rather, there was a doubling of timing because there were two separatevcpkg_installedfolders, one for OPHD and one for NAS2D. By copying from one to the other we can reduce initialization time.There is still a bit of a slowdown when building NAS2D, even when no changes need to be compiled. I'm currently uncertain of the source of this.
Work for:
Contains a fix for: