Refactor crime Difficulty setting
#1498
Merged
+28
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want this field to be before classes that need access to this field.
This makes the difficulty a required parameter.
No changes needed at point of call for this.
By making this a reference, we can no longer update what is points to, so we need to remove the `difficulty` setter method. We also don't need the setter method, since storing a reference to the original value means we always have access to the original value. We no longer need a setter method to update shadow copies of the original value.
oscar139
approved these changes
Jan 11, 2025
|
Curiously, the GCC warning mentioned in Issue #1491 seems to have gone away after commit 823aa6d, despite that commit not attempting to address the warning. Although there were changes to the constructor init-list, it was adding new parameters, not removing the |
This was referenced Jan 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set
Difficultyin constructors of crime related classes. Store aconst&to the original value, so we don't need to use setters to keep shadow copies up-to-date.Work for:
-WuninitializedwhenMapViewStateinitializesmCrimeExecution#1491Related to:
CrimeExecution#1497