DInputSource: Limit the amount of reported buttons and POV hats to what the data format supports #10162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…at the data format supports Fixes a crash when the device reports more buttons than what DIJOYSTATE2 can handle.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Fixes a crash when the device reports more buttons than what
DIJOYSTATE2can handle. Also partially reverts #10155 because it was rolled out as a tentative crash fix that didn't help - it's unlikely but not impossible IMO that valid axis-only devices exist, so it makes no sense not to allow them.Rationale behind Changes
Should fix a crash with specific DirectInput devices.
Suggested Testing Steps
Make sure that DirectInput Source gamepads didn't regress.